From: Tom Rini <trini@kernel.crashing.org>
To: Rene Rebe <rene@rocklinux-consulting.de>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
valentin@rocklinux-consulting.de
Subject: Re: [PATCH] fix compilation of ppc embedded configs
Date: Mon, 26 Apr 2004 09:46:41 -0700 [thread overview]
Message-ID: <20040426164641.GB19246@smtp.west.cox.net> (raw)
In-Reply-To: <20040422.103620.607961025.rene@rocklinux-consulting.de>
On Thu, Apr 22, 2004 at 10:36:20AM +0200, Rene Rebe wrote:
> Hi,
>
> the attached patch converts some arch/ppc/platforms/*_setup.c files to
> the new openpic_init argument cleanups and additional fixes the
> includes of platforms/pplus.c.
>
> prpmc750 config and pplus config tested and booted.
I'd like to see the hunks that aren't tested dropped as I strongly
suspect there's more subtle errors in these platforms, if the call to
openpic_init hasn't been changed. Also, why is:
> --- linux-2.6.6-rc2/arch/ppc/platforms/pplus.c 2004-04-22 10:27:16.000000000 +0200
> +++ linux-2.6.5-wip/arch/ppc/platforms/pplus.c 2004-04-18 22:36:08.000000000 +0200
> @@ -19,6 +19,7 @@
> #include <linux/kernel.h>
> #include <linux/interrupt.h>
> #include <linux/init.h>
> +#include <linux/initrd.h>
> #include <linux/ioport.h>
> #include <linux/console.h>
> #include <linux/pci.h>
Needed? Thanks.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-04-26 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-22 8:36 Rene Rebe
2004-04-26 16:46 ` Tom Rini [this message]
2004-04-26 18:22 ` Rene Rebe
2004-04-26 18:39 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040426164641.GB19246@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rene@rocklinux-consulting.de \
--cc=torvalds@osdl.org \
--cc=valentin@rocklinux-consulting.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®