Re: [PATCH] fix compilation of ppc embedded configs

[Tom Rini <trini@kernel.crashing.org>]

On Mon, Apr 26, 2004 at 08:22:57PM +0200, Rene Rebe wrote:

> Hi, (un CC'ed Linus)
> 
> On: Mon, 26 Apr 2004 09:46:41 -0700,
>     Tom Rini <trini@kernel.crashing.org> wrote:
> 
> > I'd like to see the hunks that aren't tested dropped as I strongly
> 
> If you think so - I found it logical to fix the found on the way and
> not to let too much bit-rot ...
> 
> If I have to work with one of those boards in the future I want to
> track the real problems I might encounter - and not to fix 20 obvious
> compile issues first ...

I'd really rather see a loudly broken platform than a silently broken
platform until someone with the hardware steps up and verifies that
things actually work still.

> > suspect there's more subtle errors in these platforms, if the call to
> > openpic_init hasn't been changed.  Also, why is:
> 
> > > --- linux-2.6.6-rc2/arch/ppc/platforms/pplus.c	2004-04-22 10:27:16.000000000 +0200
> > > +++ linux-2.6.5-wip/arch/ppc/platforms/pplus.c	2004-04-18 22:36:08.000000000 +0200
> > > @@ -19,6 +19,7 @@
> > >  #include <linux/kernel.h>
> > >  #include <linux/interrupt.h>
> > >  #include <linux/init.h>
> > > +#include <linux/initrd.h>
> > >  #include <linux/ioport.h>
> > >  #include <linux/console.h>
> > >  #include <linux/pci.h>
> > 
> > Needed?  Thanks.
> 
> To get the file compile - otherwise you get:
> 
> arch/ppc/platforms/pplus.c: In function `pplus_setup_arch':
> arch/ppc/platforms/pplus.c:569: `initrd_start' undeclared (first use in this function)
> arch/ppc/platforms/pplus.c:569: (Each undeclared identifier is reported only once
> arch/ppc/platforms/pplus.c:569: for each function it appears in.)
> 
> and since I do not have all the kernel kernel in my memory and the
> other files include initrd.h I thought it is the most logical thing to try ...

Good enough, thanks.

-- 
Tom Rini
http://gate.crashing.org/~trini/