From: Tom Rini <trini@kernel.crashing.org>
To: akpm@osdl.org, Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fix warning in arch/ppc/boot/simple/misc.c
Date: Wed, 28 Apr 2004 09:28:33 -0700 [thread overview]
Message-ID: <20040428162833.GL3731@smtp.west.cox.net> (raw)
In-Reply-To: <200404281614.i3SGEYMB013650@hera.kernel.org>
On Wed, Apr 28, 2004 at 03:14:38PM +0000, akpm@osdl.org wrote:
> ChangeSet 1.1596.2.5, 2004/04/28 08:14:38-07:00, akpm@osdl.org
>
> [PATCH] fix warning in arch/ppc/boot/simple/misc.c
>
> From: Christoph Hellwig <hch@lst.de>
>
> asm-ppc/elf.h uses a pointer to struct task_struct without any
> forward-declaration.
>
> In file included from include/linux/elf.h:5,
> from arch/ppc/boot/simple/misc.c:20:
> include/asm/elf.h:102: warning: `struct task_struct' declared inside parameter list
> include/asm/elf.h:102: warning: its scope is only this definition or declaration, which is probably not what you want
This patch is redundant. The correct fix, which got into -rc3, is to
drop <linux/elf.h> from the file in question.
--
Tom Rini
http://gate.crashing.org/~trini/
parent reply other threads:[~2004-04-28 22:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200404281614.i3SGEYMB013650@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040428162833.GL3731@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®