* Re: [PATCH] fix warning in arch/ppc/boot/simple/misc.c
[not found] <200404281614.i3SGEYMB013650@hera.kernel.org>
@ 2004-04-28 16:28 ` Tom Rini
0 siblings, 0 replies; only message in thread
From: Tom Rini @ 2004-04-28 16:28 UTC (permalink / raw)
To: akpm, Kernel Mailing List; +Cc: Christoph Hellwig
On Wed, Apr 28, 2004 at 03:14:38PM +0000, akpm@osdl.org wrote:
> ChangeSet 1.1596.2.5, 2004/04/28 08:14:38-07:00, akpm@osdl.org
>
> [PATCH] fix warning in arch/ppc/boot/simple/misc.c
>
> From: Christoph Hellwig <hch@lst.de>
>
> asm-ppc/elf.h uses a pointer to struct task_struct without any
> forward-declaration.
>
> In file included from include/linux/elf.h:5,
> from arch/ppc/boot/simple/misc.c:20:
> include/asm/elf.h:102: warning: `struct task_struct' declared inside parameter list
> include/asm/elf.h:102: warning: its scope is only this definition or declaration, which is probably not what you want
This patch is redundant. The correct fix, which got into -rc3, is to
drop <linux/elf.h> from the file in question.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] only message in thread