mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [USBFS PATCH] change extern inline to static inline
@ 2004-05-01 22:15 Duncan Sands
  2004-05-01 23:04 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Duncan Sands @ 2004-05-01 22:15 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-usb-devel, linux-kernel

And change __inline__ to inline and get rid of an unused function
while at it.

 devio.c |   35 +++++------------------------------
 1 files changed, 5 insertions(+), 30 deletions(-)


diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
--- a/drivers/usb/core/devio.c	Fri Apr 30 23:36:25 2004
+++ b/drivers/usb/core/devio.c	Fri Apr 30 23:36:25 2004
@@ -165,31 +165,6 @@
 	return ret;
 }
 
-extern inline unsigned int ld2(unsigned int x)
-{
-        unsigned int r = 0;
-        
-        if (x >= 0x10000) {
-                x >>= 16;
-                r += 16;
-        }
-        if (x >= 0x100) {
-                x >>= 8;
-                r += 8;
-        }
-        if (x >= 0x10) {
-                x >>= 4;
-                r += 4;
-        }
-        if (x >= 4) {
-                x >>= 2;
-                r += 2;
-        }
-        if (x >= 2)
-                r++;
-        return r;
-}
-
 /*
  * async list handling
  */
@@ -219,7 +194,7 @@
         kfree(as);
 }
 
-extern __inline__ void async_newpending(struct async *as)
+static inline void async_newpending(struct async *as)
 {
         struct dev_state *ps = as->ps;
         unsigned long flags;
@@ -229,7 +204,7 @@
         spin_unlock_irqrestore(&ps->lock, flags);
 }
 
-extern __inline__ void async_removepending(struct async *as)
+static inline void async_removepending(struct async *as)
 {
         struct dev_state *ps = as->ps;
         unsigned long flags;
@@ -239,7 +214,7 @@
         spin_unlock_irqrestore(&ps->lock, flags);
 }
 
-extern __inline__ struct async *async_getcompleted(struct dev_state *ps)
+static inline struct async *async_getcompleted(struct dev_state *ps)
 {
         unsigned long flags;
         struct async *as = NULL;
@@ -253,7 +228,7 @@
         return as;
 }
 
-extern __inline__ struct async *async_getpending(struct dev_state *ps, void __user *userurb)
+static inline struct async *async_getpending(struct dev_state *ps, void __user *userurb)
 {
         unsigned long flags;
         struct async *as;
@@ -321,7 +296,7 @@
 	destroy_async(ps, &hitlist);
 }
 
-extern __inline__ void destroy_all_async(struct dev_state *ps)
+static inline void destroy_all_async(struct dev_state *ps)
 {
 	        destroy_async(ps, &ps->async_pending);
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [USBFS PATCH] change extern inline to static inline
  2004-05-01 22:15 [USBFS PATCH] change extern inline to static inline Duncan Sands
@ 2004-05-01 23:04 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2004-05-01 23:04 UTC (permalink / raw)
  To: Duncan Sands; +Cc: linux-usb-devel, linux-kernel

On Sun, May 02, 2004 at 12:15:25AM +0200, Duncan Sands wrote:
> And change __inline__ to inline and get rid of an unused function
> while at it.

Applied, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-01 23:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-01 22:15 [USBFS PATCH] change extern inline to static inline Duncan Sands
2004-05-01 23:04 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®