mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "R. J. Wysocki" <rjwysocki@sisk.pl>
Cc: akpm@zip.com.au, ak@muc.de, linux-kernel@vger.kernel.org
Subject: Re: 2.6.6-rc3-mm2 does not build on AMD64 + essential patch is missing
Date: Wed, 5 May 2004 13:58:34 -0700	[thread overview]
Message-ID: <20040505135834.5edfa5b1.akpm@osdl.org> (raw)
In-Reply-To: <200405052210.18074.rjwysocki@sisk.pl>

"R. J. Wysocki" <rjwysocki@sisk.pl> wrote:
>
> Hi,
> 
> The 2.6.6-rc3-mm2 kernel does not buld on AMD64 w/ NUMA, it appears.  Here's 
> what the gcc says:
> 
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/x86_64/ia32/built-in.o(.text+0xa164): In function `ia32_setup_arg_pages':
> : undefined reference to `mpol_set_vma_default'
> kernel/built-in.o(.text+0x9ba0): In function `do_exit':
> : undefined reference to `mpol_free'
> make: *** [.tmp_vmlinux1] Error 1

Thanks.  The below should fix it.

> (attached is the .config).  Also, IMHO, the patch:
> 
> --- include/asm-x86_64/processor.h.orig	2004-05-05 21:35:55.890656408 +0200
> +++ include/asm-x86_64/processor.h	2004-05-05 21:41:15.930003032 +0200
> @@ -20,6 +20,8 @@
>  #include <asm/mmsegment.h>
>  #include <linux/personality.h>
>  
> +#define ARCH_MIN_TASKALIGN 16
> +
>  #define TF_MASK		0x00000100
>  #define IF_MASK		0x00000200
>  #define IOPL_MASK	0x00003000
> 
> should be applied to it, so that it does not crash at init.

Are you sure?  This patch should no longer be necessary, because the
default was changed in kernel/fork.c



diff -puN arch/ia64/ia32/binfmt_elf32.c~small-numa-api-fixups-fix arch/ia64/ia32/binfmt_elf32.c
--- 25/arch/ia64/ia32/binfmt_elf32.c~small-numa-api-fixups-fix	2004-05-05 13:37:15.909719656 -0700
+++ 25-akpm/arch/ia64/ia32/binfmt_elf32.c	2004-05-05 13:37:37.615419888 -0700
@@ -14,6 +14,7 @@
 #include <linux/types.h>
 #include <linux/mm.h>
 #include <linux/security.h>
+#include <linux/mempolicy.h>
 
 #include <asm/param.h>
 #include <asm/signal.h>
diff -puN arch/ia64/kernel/perfmon.c~small-numa-api-fixups-fix arch/ia64/kernel/perfmon.c
--- 25/arch/ia64/kernel/perfmon.c~small-numa-api-fixups-fix	2004-05-05 13:37:15.926717072 -0700
+++ 25-akpm/arch/ia64/kernel/perfmon.c	2004-05-05 13:37:45.646199024 -0700
@@ -37,6 +37,7 @@
 #include <linux/pagemap.h>
 #include <linux/mount.h>
 #include <linux/version.h>
+#include <linux/mempolicy.h>
 
 #include <asm/bitops.h>
 #include <asm/errno.h>
diff -puN arch/ia64/mm/init.c~small-numa-api-fixups-fix arch/ia64/mm/init.c
--- 25/arch/ia64/mm/init.c~small-numa-api-fixups-fix	2004-05-05 13:37:15.941714792 -0700
+++ 25-akpm/arch/ia64/mm/init.c	2004-05-05 13:37:50.909398896 -0700
@@ -19,6 +19,7 @@
 #include <linux/slab.h>
 #include <linux/swap.h>
 #include <linux/proc_fs.h>
+#include <linux/mempolicy.h>
 
 #include <asm/a.out.h>
 #include <asm/bitops.h>
diff -puN kernel/exit.c~small-numa-api-fixups-fix kernel/exit.c
--- 25/kernel/exit.c~small-numa-api-fixups-fix	2004-05-05 13:37:15.957712360 -0700
+++ 25-akpm/kernel/exit.c	2004-05-05 13:37:55.420713072 -0700
@@ -22,6 +22,7 @@
 #include <linux/profile.h>
 #include <linux/mount.h>
 #include <linux/proc_fs.h>
+#include <linux/mempolicy.h>
 
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>

_


  reply	other threads:[~2004-05-05 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-05 20:13 R. J. Wysocki
2004-05-05 20:58 ` Andrew Morton [this message]
2004-05-06 19:38   ` R. J. Wysocki
2004-05-06  7:43 ` Andi Kleen
2004-05-06  7:47   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040505135834.5edfa5b1.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ak@muc.de \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjwysocki@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®