Re: 2.6.6-rc3-mm2 does not build on AMD64 + essential patch is missing

["R. J. Wysocki" <rjwysocki@sisk.pl>]

On Wednesday 05 of May 2004 22:58, Andrew Morton wrote:
> "R. J. Wysocki" <rjwysocki@sisk.pl> wrote:
> > Hi,
> >
> > The 2.6.6-rc3-mm2 kernel does not buld on AMD64 w/ NUMA, it appears. 
> > Here's what the gcc says:
> >
> >   CC      init/version.o
> >   LD      init/built-in.o
> >   LD      .tmp_vmlinux1
> >
> > arch/x86_64/ia32/built-in.o(.text+0xa164): In function 
`ia32_setup_arg_pages':
> > : undefined reference to `mpol_set_vma_default'
> >
> > kernel/built-in.o(.text+0x9ba0): In function `do_exit':
> > : undefined reference to `mpol_free'
> >
> > make: *** [.tmp_vmlinux1] Error 1
>
> Thanks.  The below should fix it.

It does, but additionally "#include <linux/mempolicy.h>" has to be added in 
"ia32_binfmt.c":

diff -Naur linux-2.6.6-rc3-mm2/arch/x86_64/ia32/ia32_binfmt.c 
linux-2.6.6-rc3-mm2.new/arch/x86_64/ia32/ia32_binfmt.c
--- linux-2.6.6-rc3-mm2/arch/x86_64/ia32/ia32_binfmt.c	2004-05-05 
21:06:39.000000000 +0200
+++ linux-2.6.6-rc3-mm2.new/arch/x86_64/ia32/ia32_binfmt.c	2004-05-05 
21:01:43.398886976 +0200
@@ -14,6 +14,7 @@
 #include <linux/string.h>
 #include <linux/binfmts.h>
 #include <linux/mm.h>
+#include <linux/mempolicy.h>
 #include <linux/security.h>
 
 #include <asm/segment.h> 

> > (attached is the .config).  Also, IMHO, the patch:
[cut]
> > should be applied to it, so that it does not crash at init.
>
> Are you sure?  This patch should no longer be necessary, because the
> default was changed in kernel/fork.c

Of course you're right, though some other architectures (eg. i386) do have it 
(is it necessay there any longer?).

Greets,
RJW