[PATCH] XFS warning on sparc64

[PATCH] XFS warning on sparc64

[Meelis Roos]

This is 2.6.6-rc3+BK as of today on a sparc64 (gcc 3.3.3 on Debian):

  CC [M]  fs/xfs/xfs_buf_item.o
fs/xfs/xfs_buf_item.c: In function `xfs_buf_iodone_callbacks':
fs/xfs/xfs_buf_item.c:1055: warning: long long unsigned int format, xfs_daddr_t arg (arg 3)

The following patch seems to fix it - is it correct?

===== fs/xfs/xfs_buf_item.c 1.16 vs edited =====
--- 1.16/fs/xfs/xfs_buf_item.c	Mon Feb  9 06:12:20 2004
+++ edited/fs/xfs/xfs_buf_item.c	Thu May  6 20:09:01 2004
@@ -1053,7 +1053,7 @@
 		    (time_after(jiffies, (lasttime + 5*HZ)))) {
 			lasttime = jiffies;
 			prdev("XFS write error in file system meta-data "
-			      "block 0x%Lx in %s",
+			      "block 0x%Zx in %s",
 			      XFS_BUF_TARGET(bp),
 			      XFS_BUF_ADDR(bp), mp->m_fsname);
 		}


-- 
Meelis Roos (mroos@linux.ee)

Re: [PATCH] XFS warning on sparc64

[Nathan Scott]

On Thu, May 06, 2004 at 08:33:06PM +0300, Meelis Roos wrote:
> This is 2.6.6-rc3+BK as of today on a sparc64 (gcc 3.3.3 on Debian):
> 
>   CC [M]  fs/xfs/xfs_buf_item.o
> fs/xfs/xfs_buf_item.c: In function `xfs_buf_iodone_callbacks':
> fs/xfs/xfs_buf_item.c:1055: warning: long long unsigned int format, xfs_daddr_t arg (arg 3)
> 
> The following patch seems to fix it - is it correct?
> 
> ===== fs/xfs/xfs_buf_item.c 1.16 vs edited =====
> --- 1.16/fs/xfs/xfs_buf_item.c	Mon Feb  9 06:12:20 2004
> +++ edited/fs/xfs/xfs_buf_item.c	Thu May  6 20:09:01 2004
> @@ -1053,7 +1053,7 @@
>  		    (time_after(jiffies, (lasttime + 5*HZ)))) {
>  			lasttime = jiffies;
>  			prdev("XFS write error in file system meta-data "
> -			      "block 0x%Lx in %s",
> +			      "block 0x%Zx in %s",
>  			      XFS_BUF_TARGET(bp),
>  			      XFS_BUF_ADDR(bp), mp->m_fsname);
>  		}

In most other places we've used %llu and an explicit cast to 
(unsigned long long) when dumping block numbers - I'll fix
that one up.

thanks.

-- 
Nathan