mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* ppc64 HDIO_TASK_* ioctls 2.4, 2.6
@ 2004-05-12 22:09 Doug Maxey
  2004-05-12 22:47 ` Bartlomiej Zolnierkiewicz
  2004-05-13  7:30 ` Bruce Allen
  0 siblings, 2 replies; 5+ messages in thread
From: Doug Maxey @ 2004-05-12 22:09 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]


Howdy,

  I need a some guidance on enabling the ioctls on ppc64 to allow
  the smartmontools to run the appropriate set of commands.

  Does this look ok?

  Have sniff tested, and the smart tools do run without ioctl errors.

++doug


[-- Attachment #2: ppc64-26-hdio-ioctls.diff --]
[-- Type: application/octet-stream , Size: 773 bytes --]

Index: arch/ppc64/kernel/ioctl32.c
===================================================================
RCS file: /cvs/linuxppc64/sles-9-7/arch/ppc64/kernel/ioctl32.c,v
retrieving revision 1.1.1.1
diff -w -p -u -r1.1.1.1 ioctl32.c
--- arch/ppc64/kernel/ioctl32.c	4 May 2004 16:43:27 -0000	1.1.1.1
+++ arch/ppc64/kernel/ioctl32.c	10 May 2004 14:46:20 -0000
@@ -349,6 +349,11 @@ COMPATIBLE_IOCTL(TIOCSLTC)
 /* Little p (/dev/rtc, /dev/envctrl, etc.) */
 COMPATIBLE_IOCTL(_IOR('p', 20, int[7])) /* RTCGET */
 COMPATIBLE_IOCTL(_IOW('p', 21, int[7])) /* RTCSET */
+COMPATIBLE_IOCTL(HDIO_DRIVE_CMD)
+#ifdef CONFIG_IDE_TASK_IOCTL
+COMPATIBLE_IOCTL(HDIO_DRIVE_TASKFILE),
+COMPATIBLE_IOCTL(HDIO_DRIVE_TASK),
+#endif CONFIG_IDE_TASK_IOCTL
 
 /* And these ioctls need translation */
 

[-- Attachment #3: ppc64-24-hdio-ioctls.diff --]
[-- Type: application/octet-stream , Size: 822 bytes --]

Index: arch/ppc64/kernel/ioctl32.c
===================================================================
RCS file: /cvs/linuxppc64/sles8-sp3aa/arch/ppc64/kernel/ioctl32.c,v
retrieving revision 1.1.1.1
retrieving revision 1.1.1.1.2.3
diff -w -p -u -r1.1.1.1 -r1.1.1.1.2.3
--- arch/ppc64/kernel/ioctl32.c	23 Apr 2004 15:59:34 -0000	1.1.1.1
+++ arch/ppc64/kernel/ioctl32.c	6 May 2004 00:31:17 -0000	1.1.1.1.2.3
@@ -3846,6 +3846,10 @@ COMPATIBLE_IOCTL(HDIO_SET_UNMASKINTR),
 COMPATIBLE_IOCTL(HDIO_SET_NOWERR),
 COMPATIBLE_IOCTL(HDIO_SET_32BIT),
 COMPATIBLE_IOCTL(HDIO_SET_MULTCOUNT),
+#ifdef CONFIG_IDE_TASK_IOCTL
+COMPATIBLE_IOCTL(HDIO_DRIVE_TASKFILE),
+COMPATIBLE_IOCTL(HDIO_DRIVE_TASK),
+#endif CONFIG_IDE_TASK_IOCTL
 COMPATIBLE_IOCTL(HDIO_DRIVE_CMD),
 COMPATIBLE_IOCTL(HDIO_SET_PIO_MODE),
 COMPATIBLE_IOCTL(HDIO_SCAN_HWIF),

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ppc64 HDIO_TASK_* ioctls 2.4, 2.6
  2004-05-12 22:09 ppc64 HDIO_TASK_* ioctls 2.4, 2.6 Doug Maxey
@ 2004-05-12 22:47 ` Bartlomiej Zolnierkiewicz
  2004-05-13  7:30 ` Bruce Allen
  1 sibling, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-05-12 22:47 UTC (permalink / raw)
  To: Doug Maxey; +Cc: linux-kernel

On Thursday 13 of May 2004 00:09, Doug Maxey wrote:
> Howdy,
>
>   I need a some guidance on enabling the ioctls on ppc64 to allow
>   the smartmontools to run the appropriate set of commands.
>
>   Does this look ok?

+COMPATIBLE_IOCTL(HDIO_DRIVE_CMD)
+#ifdef CONFIG_IDE_TASK_IOCTL
+COMPATIBLE_IOCTL(HDIO_DRIVE_TASKFILE),
+COMPATIBLE_IOCTL(HDIO_DRIVE_TASK),
+#endif CONFIG_IDE_TASK_IOCTL
 
HDIO_DRIVE_TASK is _always_ available

>   Have sniff tested, and the smart tools do run without ioctl errors.
>
> ++doug


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ppc64 HDIO_TASK_* ioctls 2.4, 2.6
  2004-05-12 22:09 ppc64 HDIO_TASK_* ioctls 2.4, 2.6 Doug Maxey
  2004-05-12 22:47 ` Bartlomiej Zolnierkiewicz
@ 2004-05-13  7:30 ` Bruce Allen
  1 sibling, 0 replies; 5+ messages in thread
From: Bruce Allen @ 2004-05-13  7:30 UTC (permalink / raw)
  To: Doug Maxey; +Cc: Bruce Allen, Linux Kernel Mailing List

> I need a some guidance on enabling the ioctls on ppc64 to allow the
> smartmontools to run the appropriate set of commands. Does this look
> ok?  Have sniff tested, and the smart tools do run without ioctl
> errors.

Doug, "without ioctl errors" suggests that there might be *other* errors.  
If so, could you please write to smartmontools-support at lists dot sf dot
net about them?  We've tried hard to make and keep smartmontools both
64-bit and endian-order clean, but without test machines of all flavors we
rely on bug reports to keep us honest.

Cheers,
	Bruce


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ppc64 HDIO_TASK_* ioctls 2.4, 2.6
  2004-05-12 22:53 Doug Maxey
@ 2004-05-12 23:03 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-05-12 23:03 UTC (permalink / raw)
  To: Doug Maxey; +Cc: linux-kernel

On Thursday 13 of May 2004 00:53, Doug Maxey wrote:
> On Thu, 13 May 2004 00:47:49 +0200, Bartlomiej Zolnierkiewicz wrote:
> >  HDIO_DRIVE_TASK is _always_ available
>
> Yes, indeed.  Move the line, or eliminate the conditionals entirely?

Just move the line.

Regards,
Bartlomiej


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ppc64 HDIO_TASK_* ioctls 2.4, 2.6
@ 2004-05-12 22:53 Doug Maxey
  2004-05-12 23:03 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 5+ messages in thread
From: Doug Maxey @ 2004-05-12 22:53 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: linux-kernel


On Thu, 13 May 2004 00:47:49 +0200, Bartlomiej Zolnierkiewicz wrote:
>  HDIO_DRIVE_TASK is _always_ available 

Yes, indeed.  Move the line, or eliminate the conditionals entirely?

++doug



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-05-13  7:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-12 22:09 ppc64 HDIO_TASK_* ioctls 2.4, 2.6 Doug Maxey
2004-05-12 22:47 ` Bartlomiej Zolnierkiewicz
2004-05-13  7:30 ` Bruce Allen
2004-05-12 22:53 Doug Maxey
2004-05-12 23:03 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®