From: William Lee Irwin III <wli@holomorphy.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Muli Ben-Yehuda <mulix@mulix.org>,
David Gibson <david@gibson.dropbear.id.au>,
Andrew Morton <akpm@osdl.org>, Anton Blanchard <anton@samba.org>,
Adam Litke <agl@us.ibm.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linuxppc64-dev <linuxppc64-dev@lists.linuxppc.org>
Subject: Re: More convenient way to grab hugepage memory
Date: Thu, 13 May 2004 00:13:59 -0700 [thread overview]
Message-ID: <20040513071359.GU1397@holomorphy.com> (raw)
In-Reply-To: <1084432141.13731.99.camel@gaston>
On Thu, 2004-05-13 at 16:59, William Lee Irwin III wrote:
>> Atop my other patch to nuke the unused global variables, here is a patch
>> to manually inline __do_mmap_pgoff(), removing the inline usage. Untested.
>> Are you sure you want this? #ifdef'ing out the hugetlb case is somewhat
>> more digestible with the inline in place, e.g.:
On Thu, May 13, 2004 at 05:09:01PM +1000, Benjamin Herrenschmidt wrote:
> Well, I did the breakup in 2 pieces in the first place for 2 reasons:
> - the original patch had some subtle issues with accounting
> - do_mmap_pgoff is already such a mess, let's not make it worse
> I mean, it's awful to get anything right in this function, especially
> the cleanup/exit path, which is why I think it's more maintainable
> cut in 2.
Well, writing it vaguely convinced me that it wasn't a great idea; I
suppose now that Muli can look at the result he'll be convinced likewise.
-- wli
next prev parent reply other threads:[~2004-05-13 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-13 5:55 David Gibson
2004-05-13 6:05 ` Muli Ben-Yehuda
2004-05-13 6:20 ` David Gibson
2004-05-13 6:45 ` Roland Dreier
2004-05-13 6:59 ` William Lee Irwin III
2004-05-13 7:04 ` William Lee Irwin III
2004-05-13 7:11 ` William Lee Irwin III
2004-05-13 7:09 ` Benjamin Herrenschmidt
2004-05-13 7:13 ` William Lee Irwin III [this message]
2004-05-13 8:05 ` Muli Ben-Yehuda
2004-05-13 6:06 ` William Lee Irwin III
2004-05-13 6:27 ` William Lee Irwin III
2004-05-13 7:49 ` Christoph Hellwig
2004-05-13 8:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040513071359.GU1397@holomorphy.com \
--to=wli@holomorphy.com \
--cc=agl@us.ibm.com \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=mulix@mulix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®