mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Muli Ben-Yehuda <mulix@mulix.org>, Andrew Morton <akpm@osdl.org>,
	Anton Blanchard <anton@samba.org>, Adam Litke <agl@us.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-kernel@vger.kernel.org, linuxppc64-dev@lists.linuxppc.org
Subject: Re: More convenient way to grab hugepage memory
Date: 12 May 2004 23:45:57 -0700	[thread overview]
Message-ID: <52wu3g9656.fsf@topspin.com> (raw)
In-Reply-To: <20040513062014.GJ27403@zax>

    David> Well, it's only called in one place - it's really the one
    David> function, just split up to let us put the wrapper creating
    David> the hugetlb file in the right place without excessive
    David> indentation.  I guess it doesn't really matter, with
    David> -funit-at-a-time it will end up the same anyway.

We seem to be in a strange situation with respect to -funit-at-a-time:

    arch/i386/Makefile:
    # Disable unit-at-a-time mode, it makes gcc use a lot more stack
    # due to the lack of sharing of stacklots.
    CFLAGS += $(call check_gcc,-fno-unit-at-a-time,)

    arch/x86_64/Makefile:
    # -funit-at-a-time shrinks the kernel .text considerably
    # unfortunately it makes reading oopses harder.
    CFLAGS += $(call check_gcc,-funit-at-a-time,)

    arch/ppc64/Makefile:
    # Enable unit-at-a-time mode when possible. It shrinks the
    # kernel considerably.
    CFLAGS += $(call check_gcc,-funit-at-a-time,)

It looks like i386/x86_64 led the way to -funit-at-a-time, ppc64
followed, and then i386 had second thoughts because of increased stack
usage around the time of 4K stacks.

No other archs have a position one way or another.

 -  Roland

  reply	other threads:[~2004-05-13  6:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-13  5:55 David Gibson
2004-05-13  6:05 ` Muli Ben-Yehuda
2004-05-13  6:20   ` David Gibson
2004-05-13  6:45     ` Roland Dreier [this message]
2004-05-13  6:59   ` William Lee Irwin III
2004-05-13  7:04     ` William Lee Irwin III
2004-05-13  7:11       ` William Lee Irwin III
2004-05-13  7:09     ` Benjamin Herrenschmidt
2004-05-13  7:13       ` William Lee Irwin III
2004-05-13  8:05         ` Muli Ben-Yehuda
2004-05-13  6:06 ` William Lee Irwin III
2004-05-13  6:27   ` William Lee Irwin III
2004-05-13  7:49 ` Christoph Hellwig
2004-05-13  8:06   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52wu3g9656.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=agl@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@lists.linuxppc.org \
    --cc=mulix@mulix.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®