mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Domsch <Matt_Domsch@dell.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>, "Randy.Dunlap" <rddunlap@osdl.org>,
	matthew.e.tolentino@intel.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6.6-mm2: EFI_VARS=m is broken
Date: Thu, 13 May 2004 10:03:40 -0500	[thread overview]
Message-ID: <20040513150340.GA19597@lists.us.dell.com> (raw)
In-Reply-To: <20040513133806.GD22202@fs.tum.de>

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

On Thu, May 13, 2004 at 03:38:06PM +0200, Adrian Bunk wrote:
> On Thu, May 13, 2004 at 03:27:36AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.6-mm1:
> >...
> > +efivars-fix.patch
> > 
> >  Fix oops with efivars enabled but not avaialble.
> 
> This patch broke EFI_VARS=m:

Duh.  i386 needs to export efi_enabled.  ia64 doesn't as it's a
#define in linux/efi.h.  Matt T, are you working on EFI for x86_64
too?  Patch below for i386.


-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com


Export efi_enabled to modules such as efivars.  Only needed on i386 at
present, as ia64 has this as a #define in linux/efi.h, and EFI isn't
available for other arches.


===== arch/i386/kernel/setup.c 1.118 vs edited =====
--- 1.118/arch/i386/kernel/setup.c	Wed Apr 28 02:09:40 2004
+++ edited/arch/i386/kernel/setup.c	Thu May 13 09:58:01 2004
@@ -65,6 +65,7 @@
 
 #ifdef CONFIG_EFI
 int efi_enabled = 0;
+EXPORT_SYMBOL(efi_enabled);
 #endif
 
 /* cpu data as detected by the assembly code in head.S */

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-05-13 15:05 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-13 10:27 2.6.6-mm2 Andrew Morton
2004-05-13 10:45 ` 2.6.6-mm2 Christoph Hellwig
2004-05-13 10:51   ` 2.6.6-mm2 Andrew Morton
2004-05-13 11:12     ` 2.6.6-mm2 Christoph Hellwig
2004-05-13 11:25       ` 2.6.6-mm2 Andrew Morton
2004-05-13 13:18         ` 2.6.6-mm2 Adrian Bunk
2004-05-13 13:39           ` 2.6.6-mm2 Chris Mason
2004-05-13 14:09             ` 2.6.6-mm2 Adrian Bunk
2004-05-17 20:52               ` 2.6.6-mm2 Bill Davidsen
2004-05-14  7:30       ` 2.6.6-mm2 Ian Kent
2004-05-13 14:15     ` 2.6.6-mm2 Adrian Bunk
2004-05-13 19:18     ` 2.6.6-mm2 Chris Wright
2004-05-13 19:29       ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:35         ` 2.6.6-mm2 Chris Wright
2004-05-13 19:38       ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:42         ` 2.6.6-mm2 Chris Wright
2004-05-14 19:14           ` 2.6.6-mm2 Andrea Arcangeli
2004-05-14 20:58             ` 2.6.6-mm2 Chris Wright
2004-05-15  2:43               ` 2.6.6-mm2 Andrea Arcangeli
2004-05-15  7:43                 ` 2.6.6-mm2 Hugh Dickins
2004-05-14 19:06         ` 2.6.6-mm2 Kevin O'Connor
2004-05-14 19:36           ` 2.6.6-mm2 Chris Wright
2004-05-14 19:42           ` 2.6.6-mm2 Kevin O'Connor
2004-05-13 10:53 ` 2.6.6-mm2, usb ehci warnings/error? Prakash K. Cheemplavam
2004-05-13 12:11   ` 2.6.6-mm-rc3-mm2 USB 2.0 after suspend issue Ari Pollak
2004-05-13 12:14 ` 2.6.6-mm2 Matt H.
2004-05-13 18:24   ` 2.6.6-mm2 Andrew Morton
2004-05-13 22:40     ` 2.6.6-mm2 Greg KH
2004-05-13 12:54 ` i810 AGP fails to initialise (was Re: 2.6.6-mm2) Sean Neakums
2004-05-13 13:53   ` Dave Jones
2004-05-13 13:58     ` Andi Kleen
2004-05-13 14:02       ` Sean Neakums
2004-05-13 15:41         ` Andi Kleen
2004-05-14  3:47           ` Clemens Schwaighofer
2004-05-14  7:42           ` Sean Neakums
2004-05-15  9:52             ` Sean Neakums
2004-05-17  8:49               ` Sean Neakums
2004-05-17 10:01                 ` Andi Kleen
2004-05-17 11:04                   ` Sean Neakums
2004-05-17 11:46                     ` Andi Kleen
2004-05-17 12:37                       ` Sean Neakums
2004-05-13 13:38 ` 2.6.6-mm2: EFI_VARS=m is broken Adrian Bunk
2004-05-13 15:03   ` Matt Domsch [this message]
2004-05-13 13:42 ` 2.6.6-mm2 Paolo Ornati
2004-05-13 14:01   ` 2.6.6-mm2: bk-driver-core-module-fix.patch no longer required Adrian Bunk
2004-05-13 14:36     ` Paolo Ornati
2004-05-13 15:07 ` 2.6.6-mm2 Lorenzo Allegrucci
2004-05-13 18:55   ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:41     ` 2.6.6-mm2 Lorenzo Allegrucci
2004-05-14 17:48 ` 2.6.6-mm2 R. J. Wysocki
2004-05-14 17:47   ` 2.6.6-mm2 Christoph Hellwig
2004-05-14 21:20     ` 2.6.6-mm2 R. J. Wysocki
2004-05-14 23:56 ` 2.6.6-mm2 Joseph Fannin
2004-05-14 23:58   ` 2.6.6-mm2 Chris Wright
2004-05-13 15:14 2.6.6-mm2: EFI_VARS=m is broken Tolentino, Matthew E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040513150340.GA19597@lists.us.dell.com \
    --to=matt_domsch@dell.com \
    --cc=akpm@osdl.org \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.e.tolentino@intel.com \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®