From: bert hubert <ahu@ds9a.nl>
To: Fruhwirth Clemens <clemens-dated-1085404045.d167@endorphin.org>
Cc: linux-kernel@vger.kernel.org,
Christophe Saout <christophe@saout.de>,
Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
James Morris <jmorris@redhat.com>
Subject: Re: [PATCH] AES i586 optimized, regparm fixed
Date: Fri, 14 May 2004 15:26:15 +0200 [thread overview]
Message-ID: <20040514132615.GA21039@outpost.ds9a.nl> (raw)
In-Reply-To: <20040514130724.GA8081@ghanima.endorphin.org>
On Fri, May 14, 2004 at 03:07:24PM +0200, Fruhwirth Clemens wrote:
> +config CRYPTO_AES_586
> + tristate "AES cipher algorithms (586)"
> + depends on CRYPTO && X86 && !X86_64
> + help
> + AES cipher algorithms (FIPS-197). AES uses the Rijndael
> + algorithm.
I'm wondering if this should be a configurable setting. Reminds me of older
programs asking if they should do something using the 'fast' or 'slow'
algorithm, even though results were identical.
If we trust the AES assembler code, and it is supposed to be faster on >586,
it should be the default on those CPUs as there is no gain in using the C version.
On the other hand, if we think there are situations when the new assembler
code won't be correct or faster, we should not merge it.
In any case, Kconfig does not seem the way to go.
--
http://www.PowerDNS.com Open source, database driven DNS Software
http://lartc.org Linux Advanced Routing & Traffic Control HOWTO
next prev parent reply other threads:[~2004-05-14 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 13:07 Fruhwirth Clemens
2004-05-14 13:19 ` Christoph Hellwig
2004-05-14 13:40 ` Fruhwirth Clemens
2004-05-14 13:26 ` bert hubert [this message]
2004-05-14 13:48 ` James Morris
2004-05-14 14:25 ` Fruhwirth Clemens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040514132615.GA21039@outpost.ds9a.nl \
--to=ahu@ds9a.nl \
--cc=christophe@saout.de \
--cc=clemens-dated-1085404045.d167@endorphin.org \
--cc=felipe_alfaro@linuxmail.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®