From: Fruhwirth Clemens <clemens-dated-1085406027.0ed2@endorphin.org>
To: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
Christophe Saout <christophe@saout.de>,
Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
James Morris <jmorris@redhat.com>
Subject: Re: [PATCH] AES i586 optimized, regparm fixed
Date: Fri, 14 May 2004 15:40:26 +0200 [thread overview]
Message-ID: <20040514134026.GA8435@ghanima.endorphin.org> (raw)
In-Reply-To: <20040514141923.A24264@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Fri, May 14, 2004 at 02:19:23PM +0100, Christoph Hellwig wrote:
> We usually use asmlinkage instead of __attribute__((regparm(0))). while
> it's not nessecary for x86-specific code to abstract this out it at least
> looks cleaner.
I will change that.
> BTW, is the assembly code shared with some other project?
> If not it might be a good idea to kill the ifdefs in there.
The only project I'm aware of is loop-aes. aes-i586-asm.S is different wrt
to the parameter positions anyway (cryptoapi source/dest switched). The code
is not subject to regular modifications so, we might kill the #if directives
if we like.
Regards, Clemens
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-05-14 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 13:07 Fruhwirth Clemens
2004-05-14 13:19 ` Christoph Hellwig
2004-05-14 13:40 ` Fruhwirth Clemens [this message]
2004-05-14 13:26 ` bert hubert
2004-05-14 13:48 ` James Morris
2004-05-14 14:25 ` Fruhwirth Clemens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040514134026.GA8435@ghanima.endorphin.org \
--to=clemens-dated-1085406027.0ed2@endorphin.org \
--cc=christophe@saout.de \
--cc=felipe_alfaro@linuxmail.org \
--cc=hch@infradead.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®