2.6.6-bk9 - compile failure if sysfs disabled

2.6.6-bk9 - compile failure if sysfs disabled

[Mike Houston]

If sysfs is disabled in the config under pseudo filesystems,

lib/kobject.c: In function `kobject_rename':
lib/kobject.c:395: error: void value not ignored as it ought to be
make[1]: *** [lib/kobject.o] Error 1
make: *** [lib] Error 2

Line 395 is this:
error = sysfs_rename_dir(kobj, new_name);

Now, before anyone chides me for blindly disabling sysfs, I only came across this in helping someone else, who erroneously disabled it, solve this build failure :-)

My apologies if this is already known or expected. It just seems to me that it ought not to end in a build failure and is possibly something you folks would like to know about.

Note that I'm not saying this started in -bk9 because I've never previously compiled one without sysfs. This is, however, what the original user was building.

Thanks folks (for everything you do),
Mike

Re: 2.6.6-bk9 - compile failure if sysfs disabled

[Randy.Dunlap]

On Sat, 22 May 2004 23:26:28 -0400 Mike Houston <mikeserv@bmts.com> wrote:

| If sysfs is disabled in the config under pseudo filesystems,
| 
| lib/kobject.c: In function `kobject_rename':
| lib/kobject.c:395: error: void value not ignored as it ought to be
| make[1]: *** [lib/kobject.o] Error 1
| make: *** [lib] Error 2
| 
| Line 395 is this:
| error = sysfs_rename_dir(kobj, new_name);

Fix was posted Friday 2004-05-21 at 14:55 by Maneesh Soni.
Please check your favorite lkml archive for the patch.

| Now, before anyone chides me for blindly disabling sysfs, I only came across this in helping someone else, who erroneously disabled it, solve this build failure :-)
| 
| My apologies if this is already known or expected. It just seems to me that it ought not to end in a build failure and is possibly something you folks would like to know about.
| 
| Note that I'm not saying this started in -bk9 because I've never previously compiled one without sysfs. This is, however, what the original user was building.

BTW, please tell your sylpheed client to wrap lines around 70 characters
each instead of flowing them longer.

--
~Randy