From: hch@infradead.org
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Leonardo Macchia <leo@bononia.it>,
250477@bugs.debian.org, Neil Brown <neilb@cse.unsw.edu.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Bug#250477: kernel-source-2.4.26: Lots of debug in RAID5
Date: Sun, 23 May 2004 07:16:22 -0400 [thread overview]
Message-ID: <20040523111622.GA24817@infradead.org> (raw)
In-Reply-To: <20040523105351.GB19402@gondor.apana.org.au>
On Sun, May 23, 2004 at 08:53:51PM +1000, Herbert Xu wrote:
> > --- kernel-source-2.4.26/drivers/md/raid5.c 2003-08-30 06:01:38.000000000 +0000
> > +++ kernel-source-2.4.26-nodebug/drivers/md/raid5.c 2004-05-23 08:54:36.000000000 +0000
> > @@ -282,7 +282,7 @@
> > }
> >
> > if (conf->buffer_size != size) {
> > - printk("raid5: switching cache buffer size, %d --> %d\n", oldsize, size);
> > + PRINTK("raid5: switching cache buffer size, %d --> %d\n", oldsize, size);
> > shrink_stripe_cache(conf);
> > if (size==0) BUG();
> > conf->buffer_size = size;
>
> Thanks for the patch. This does indeed look like a typo.
>
> Hi Neil, does this patch look OK to you?
No, this was rejected a few times already. The problem is that XFS
uses differen I/O sizes for the log and other I/O which makes raid
performance suck really badly. The real fix is to use the v2 XFS log
format when using software raid5.
next prev parent reply other threads:[~2004-05-23 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040523085801.2878013C002@nomade.ciram.unibo.it>
2004-05-23 10:53 ` Herbert Xu
2004-05-23 11:16 ` hch [this message]
2004-05-24 1:00 ` Nathan Scott
2004-05-25 6:29 ` Neil Brown
2004-05-25 7:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040523111622.GA24817@infradead.org \
--to=hch@infradead.org \
--cc=250477@bugs.debian.org \
--cc=herbert@gondor.apana.org.au \
--cc=leo@bononia.it \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®