From: Andrew Morton <akpm@osdl.org>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: nathans@sgi.com, hch@infradead.org, herbert@gondor.apana.org.au,
leo@bononia.it, 250477@bugs.debian.org, neilb@cse.unsw.edu.au,
linux-kernel@vger.kernel.org
Subject: Re: Bug#250477: kernel-source-2.4.26: Lots of debug in RAID5
Date: Tue, 25 May 2004 00:46:21 -0700 [thread overview]
Message-ID: <20040525004621.02d7ae42.akpm@osdl.org> (raw)
In-Reply-To: <16562.59365.755616.435629@cse.unsw.edu.au>
Neil Brown <neilb@cse.unsw.edu.au> wrote:
>
> - printk("raid5: switching cache buffer size, %d --> %d\n", oldsize, size);
> + static long recent;
> + static int cnt;
> + static int warned;
> + if (time_after(recent+HZ, jiffies))
> + cnt++;
> + else {
> + recent = jiffies;
> + cnt = 0;
> + }
> + if (cnt > 50 && ! warned) {
> + printk("raid5: WARNING:array used in unsupported configuration, expect poor performance\n");
> + warned = 1;
> + }
> + if (!warned)
> + printk("raid5: switching cache buffer size, %d --> %d\n", oldsize, size);
Is it not possible to use __printk_ratelimit() in here?
prev parent reply other threads:[~2004-05-25 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040523085801.2878013C002@nomade.ciram.unibo.it>
2004-05-23 10:53 ` Herbert Xu
2004-05-23 11:16 ` hch
2004-05-24 1:00 ` Nathan Scott
2004-05-25 6:29 ` Neil Brown
2004-05-25 7:46 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040525004621.02d7ae42.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=250477@bugs.debian.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=leo@bononia.it \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®