mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* EAGAIN in do_mmap_pgoff() [2.6.7-rc1]
@ 2004-05-24 20:21 Herbert Poetzl
  2004-05-24 20:36 ` Chris Wright
  0 siblings, 1 reply; 2+ messages in thread
From: Herbert Poetzl @ 2004-05-24 20:21 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel


just a short question:

is -EAGAIN here really intentional? wouldn't -ENOMEM be better?

mm/mmap.c ~780 do_mmap_pgoff()

        /* mlock MCL_FUTURE? */
        if (vm_flags & VM_LOCKED) {
                unsigned long locked = mm->locked_vm << PAGE_SHIFT;
                locked += len;
                if (locked > current->rlim[RLIMIT_MEMLOCK].rlim_cur)
                        return -EAGAIN;
        }

TIA,
Herbert


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: EAGAIN in do_mmap_pgoff() [2.6.7-rc1]
  2004-05-24 20:21 EAGAIN in do_mmap_pgoff() [2.6.7-rc1] Herbert Poetzl
@ 2004-05-24 20:36 ` Chris Wright
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Wright @ 2004-05-24 20:36 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel

* Herbert Poetzl (herbert@13thfloor.at) wrote:
> 
> just a short question:
> 
> is -EAGAIN here really intentional? wouldn't -ENOMEM be better?
> 
> mm/mmap.c ~780 do_mmap_pgoff()
> 
>         /* mlock MCL_FUTURE? */
>         if (vm_flags & VM_LOCKED) {
>                 unsigned long locked = mm->locked_vm << PAGE_SHIFT;
>                 locked += len;
>                 if (locked > current->rlim[RLIMIT_MEMLOCK].rlim_cur)
>                         return -EAGAIN;
>         }

Standards require this one:

[EAGAIN]
	[ML] The mapping could not be locked in memory, if required by
	     mlockall(), due to a lack of resources.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-24 20:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-24 20:21 EAGAIN in do_mmap_pgoff() [2.6.7-rc1] Herbert Poetzl
2004-05-24 20:36 ` Chris Wright

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®