mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Duncan Sands <baldrick@free.fr>
To: Keith Owens <kaos@sgi.com>, Zwane Mwaikambo <zwane@fsmlabs.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.6-mm] i386: enable interrupts on contention in spin_lock_irq
Date: Wed, 26 May 2004 09:58:21 +0200	[thread overview]
Message-ID: <200405260958.21252.baldrick@free.fr> (raw)
In-Reply-To: <14280.1085556586@kao2.melbourne.sgi.com>

> However I have seen buggy code where spin_lock_irq() was issued with
> interrupts disabled. [...]

Some time ago I sent a patch to lkml that tests for this [1].
And guess what - it happens all over the place [2].  Also, the
scheduler often gets called with interrupts disabled (schedule()
does spin_lock_irq), but the cases I checked all turned out to be
OK [3].  Perhaps it is more problematic now?

Ciao,

Duncan.

[1] http://seclists.org/lists/linux-kernel/2003/May/5585.html
[2] http://seclists.org/lists/linux-kernel/2003/May/5842.html
[3] http://seclists.org/lists/linux-kernel/2003/May/5581.html

  parent reply	other threads:[~2004-05-26  7:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-26  7:11 Zwane Mwaikambo
2004-05-26  7:29 ` Keith Owens
2004-05-26  7:48   ` Zwane Mwaikambo
2004-05-26  7:58   ` Duncan Sands [this message]
2004-05-26  8:11     ` Zwane Mwaikambo
2004-05-27  1:45       ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405260958.21252.baldrick@free.fr \
    --to=baldrick@free.fr \
    --cc=akpm@osdl.org \
    --cc=kaos@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@fsmlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®