mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zwane Mwaikambo <zwane@fsmlabs.com>
To: Keith Owens <kaos@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.6-mm] i386: enable interrupts on contention in spin_lock_irq
Date: Wed, 26 May 2004 03:48:31 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0405260345470.1794@montezuma.fsmlabs.com> (raw)
In-Reply-To: <14280.1085556586@kao2.melbourne.sgi.com>

On Wed, 26 May 2004, Keith Owens wrote:

> Your patch opens a window where data that was protected by the disabled
> interrupt on entry becomes unprotected while waiting for the lock and
> can therefore change.
>
> It could be that I am worrying unnecessarily, after all any code that
> calls spin_lock_irq() with interrupts already disabled is probably
> wrong to start off with.  But it does need to be considered as a
> possible failure mode.

Granted there might be code like that, i'll throw in some debugging code
locally to test for such a condition. It wouldn't necessarily be a bug but
a very uncool way of obfuscating the locking.

Thanks,
	Zwane


  reply	other threads:[~2004-05-26  7:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-26  7:11 Zwane Mwaikambo
2004-05-26  7:29 ` Keith Owens
2004-05-26  7:48   ` Zwane Mwaikambo [this message]
2004-05-26  7:58   ` Duncan Sands
2004-05-26  8:11     ` Zwane Mwaikambo
2004-05-27  1:45       ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0405260345470.1794@montezuma.fsmlabs.com \
    --to=zwane@fsmlabs.com \
    --cc=akpm@osdl.org \
    --cc=kaos@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®