From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Sau Dan Lee <danlee@informatik.uni-freiburg.de>
Cc: linux-kernel@vger.kernel.org,
Tuukka Toivonen <tuukkat@ee.oulu.fi>,
Andries Brouwer <aeb@cwi.nl>, Vojtech Pavlik <vojtech@suse.cz>
Subject: RE: [PATCH] serio.c: dynamically control serio ports bindings via procfs (Was: [RFC/RFT] Raw access to serio ports)
Date: Wed, 2 Jun 2004 12:09:27 -0700 (PDT) [thread overview]
Message-ID: <20040602190927.79289.qmail@web81306.mail.yahoo.com> (raw)
Sau Dan Lee wrote:
>
> I've added procfs support to serio.c, so that we can now control
> dynamically which serio ports connect to which serio devices. I call
> it "serio_switch", because it conceptually works like a patch panel or
> a switch with which you can rewire the connections.
Let me start with saying that this is a very good patch and that is
exactly what I have in mind with regard to serio port/device binding.
The only problem with the patch is that it uses wrong foundation, namely
procfs, because:
- procfs hierarchy is disconnected from the rest of the system. You
cannot trace device ownership starting with root PCI bus down to your
AUX port.
- there is no automatic hotplug notification to the userspace
- it is not flexible with regard to adding custom attributes to the
drivers. I can see you adding rate and resolution to psmouse driver
and repeat rate to atkbd. With sysfs drivers can themselves create
attributes and they will be cleaned up once device disappears. With
procfs you will have to export it form serio to be available to
drivers and cleanup can be a nightmare.
Of course sysfs has its "problems" - it requires users to follow certain
lifetime rules which are different from what serio uses at the moment.
So we have several options - if we adopt procfs based solution now we
will have to maintain it for very long time, along with competing sysfs
implementation. Dropping one kernel parameter which will never be widely
used is much easier, IMO.
So I propose we all join our ranks and tame that sysfs together ;) I had
some patches that were converting drivers to the sysfs adding them to
serio bus, I probably should just send what I have as is for review
(I was going to rediff them as they are somewhat stale, I'll see what
shape they are later tonight).
--
Dmitry
next reply other threads:[~2004-06-02 19:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 19:09 Dmitry Torokhov [this message]
2004-06-03 5:54 ` Sau Dan Lee
2004-06-03 6:16 ` Dmitry Torokhov
2004-06-03 6:45 ` Sau Dan Lee
2004-06-03 6:58 ` Dmitry Torokhov
2004-06-03 7:22 ` Sau Dan Lee
2004-06-03 7:39 ` Dmitry Torokhov
2004-06-03 7:47 ` Sau Dan Lee
-- strict thread matches above, loose matches on Subject: below --
2004-06-02 9:49 [RFC/RFT] Raw access to serio ports (2/2) Sau Dan Lee
2004-06-02 12:33 ` Dmitry Torokhov
2004-06-02 17:24 ` [PATCH] serio.c: dynamically control serio ports bindings via procfs (Was: [RFC/RFT] Raw access to serio ports) Sau Dan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040602190927.79289.qmail@web81306.mail.yahoo.com \
--to=dtor_core@ameritech.net \
--cc=aeb@cwi.nl \
--cc=danlee@informatik.uni-freiburg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tuukkat@ee.oulu.fi \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®