From: Sau Dan Lee <danlee@informatik.uni-freiburg.de>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org,
Tuukka Toivonen <tuukkat@ee.oulu.fi>,
Andries Brouwer <aeb@cwi.nl>, Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [PATCH] serio.c: dynamically control serio ports bindings via procfs (Was: [RFC/RFT] Raw access to serio ports)
Date: 03 Jun 2004 07:54:33 +0200 [thread overview]
Message-ID: <xb7smdd425i.fsf@savona.informatik.uni-freiburg.de> (raw)
In-Reply-To: <20040602190927.79289.qmail@web81306.mail.yahoo.com>
>>>>> "Dmitry" == Dmitry Torokhov <dtor_core@ameritech.net> writes:
Dmitry> Let me start with saying that this is a very good patch
Dmitry> and that is exactly what I have in mind with regard to
Dmitry> serio port/device binding. The only problem with the
Dmitry> patch is that it uses wrong foundation, namely procfs,
Dmitry> because:
...
Dmitry> So we have several options - if we adopt procfs based
Dmitry> solution now we will have to maintain it for very long
Dmitry> time, along with competing sysfs implementation. Dropping
Dmitry> one kernel parameter which will never be widely used is
Dmitry> much easier, IMO.
It's not just the matter of dropping one kernel parameter. The procfs
support, _already implemented_, allows one to fine-tune the binding
between serio ports and devices, which is a new and useful feature
that your kernel parameter doesn't provide.
Can you unbind the keyboard port? Can you bind/unbind any of the AUX
ports *dynamically* without reloading the i8042 module? These
functionalities are already there in the serio-related code. Just a
userland interface is missing. My patch is to fill this gap.
Dmitry> So I propose we all join our ranks and tame that sysfs
Dmitry> together ;) I had some patches that were converting
Dmitry> drivers to the sysfs adding them to serio bus,
sysfs looks good for simple parameters: integers, strings. For
anything more complicated (sets, graphs), I don't see it fit (yet).
Unfortunately, the serio port<-->device relation is already a graph (1
to n).
I'd like to see how you implement the device<-->handler binding in
input.c using sysfs. It'd be a nice feature. Imagine how annoying it
is for 'evbug' to report your keypresses, when you're just debugging a
mouse driver. Being able to adjust the device<-->handler binding is
what I want. I don't care whether it's a procfs approach or sysfs
approach, as long as it is reasonably useable. (You could even do it
with ioctl(), if you provide a nice command line tool so that I don't
need to care about the ioctl parameters.) I'm not going to touch
input.c, because I don't want to reboot everytime to test a
modification. It's hard to compile input.c as a module.
--
Sau Dan LEE 李守敦(Big5) ~{@nJX6X~}(HZ)
E-mail: danlee@informatik.uni-freiburg.de
Home page: http://www.informatik.uni-freiburg.de/~danlee
next prev parent reply other threads:[~2004-06-03 5:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 19:09 Dmitry Torokhov
2004-06-03 5:54 ` Sau Dan Lee [this message]
2004-06-03 6:16 ` Dmitry Torokhov
2004-06-03 6:45 ` Sau Dan Lee
2004-06-03 6:58 ` Dmitry Torokhov
2004-06-03 7:22 ` Sau Dan Lee
2004-06-03 7:39 ` Dmitry Torokhov
2004-06-03 7:47 ` Sau Dan Lee
-- strict thread matches above, loose matches on Subject: below --
2004-06-02 9:49 [RFC/RFT] Raw access to serio ports (2/2) Sau Dan Lee
2004-06-02 12:33 ` Dmitry Torokhov
2004-06-02 17:24 ` [PATCH] serio.c: dynamically control serio ports bindings via procfs (Was: [RFC/RFT] Raw access to serio ports) Sau Dan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xb7smdd425i.fsf@savona.informatik.uni-freiburg.de \
--to=danlee@informatik.uni-freiburg.de \
--cc=aeb@cwi.nl \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tuukkat@ee.oulu.fi \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®