* [PATCH] Trivial, add missing newline at EOF in Documentation/networking/packet_mmap.txt
@ 2004-06-05 0:09 Jesper Juhl
2004-06-06 19:43 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2004-06-05 0:09 UTC (permalink / raw)
To: linux-kernel; +Cc: trivial
Missing newlines at the end of files make them less pleasing to work with
for a number of tools that work on a line-by-line basis, and for source files
it will cause gcc to emit a warning. So, I desided to add that missing
newline to the few files in the kernel that are missing it.
This patch makes no functional changes at all to the kernel.
Patch is against 2.6.7-rc2
Here's the patch adding a newline to Documentation/networking/packet_mmap.txt
--- linux-2.6.7-rc2/Documentation/networking/packet_mmap.txt-orig 2004-06-05 01:45:05.000000000 +0200
+++ linux-2.6.7-rc2/Documentation/networking/packet_mmap.txt 2004-06-05 01:45:22.000000000 +0200
@@ -409,4 +409,4 @@ then poll for frames.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
-More majordomo info at http://vger.kernel.org/majordomo-info.html
\ No newline at end of file
+More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jesper Juhl <juhl-lkml@dif.dk>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Trivial, add missing newline at EOF in Documentation/networking/packet_mmap.txt
2004-06-05 0:09 [PATCH] Trivial, add missing newline at EOF in Documentation/networking/packet_mmap.txt Jesper Juhl
@ 2004-06-06 19:43 ` Pavel Machek
2004-06-08 23:07 ` Jesper Juhl
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2004-06-06 19:43 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-kernel, trivial
Hi!
> Missing newlines at the end of files make them less pleasing to work with
> for a number of tools that work on a line-by-line basis, and for source files
> it will cause gcc to emit a warning. So, I desided to add that missing
> newline to the few files in the kernel that are missing it.
> This patch makes no functional changes at all to the kernel.
> Patch is against 2.6.7-rc2
>
> Here's the patch adding a newline to
> Documentation/networking/packet_mmap.txt
Perhaps you should strip headers/lkml signature of packet_mmap.txt?
Pavel
--
934a471f20d6580d5aad759bf0d97ddc
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Trivial, add missing newline at EOF in Documentation/networking/packet_mmap.txt
2004-06-06 19:43 ` Pavel Machek
@ 2004-06-08 23:07 ` Jesper Juhl
0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2004-06-08 23:07 UTC (permalink / raw)
To: Pavel Machek
Cc: linux-kernel, trivial, David S. Miller, Ulisses Alonso Camaró
On Sun, 6 Jun 2004, Pavel Machek wrote:
> Hi!
>
> > Missing newlines at the end of files make them less pleasing to work with
> > for a number of tools that work on a line-by-line basis, and for source files
> > it will cause gcc to emit a warning. So, I desided to add that missing
> > newline to the few files in the kernel that are missing it.
> > This patch makes no functional changes at all to the kernel.
> > Patch is against 2.6.7-rc2
> >
> > Here's the patch adding a newline to
> > Documentation/networking/packet_mmap.txt
>
> Perhaps you should strip headers/lkml signature of packet_mmap.txt?
> Pavel
That makes sense to me, here's an updated patch against 2.6.7-rc3
(adding David S. Miller and Ulisses Alonso Camaró to the CC list since the
comment I'm removing at the top involves them (hope I got the right
persons behind "DaveM" & "Ulisses" there)) :
--- linux-2.6.7-rc3/Documentation/networking/packet_mmap.txt-orig 2004-06-09 00:58:12.000000000 +0200
+++ linux-2.6.7-rc3/Documentation/networking/packet_mmap.txt 2004-06-09 00:58:30.000000000 +0200
@@ -1,11 +1,4 @@
-DaveM:
-
-If you agree with it I will send two small patches to modify
-kernel's configure help.
-
- Ulisses
-
--------------------------------------------------------------------------------
+ ABSTRACT
--------------------------------------------------------------------------------
@@ -405,8 +398,3 @@ then poll for frames.
Jesse Brandeburg, for fixing my grammathical/spelling errors
->>> EOF
--
-To unsubscribe from this list: send the line "unsubscribe linux-net" in
-the body of a message to majordomo@vger.kernel.org
-More majordomo info at http://vger.kernel.org/majordomo-info.html
\ No newline at end of file
--
Jesper Juhl <juhl-lkml@dif.dk>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-06-08 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-05 0:09 [PATCH] Trivial, add missing newline at EOF in Documentation/networking/packet_mmap.txt Jesper Juhl
2004-06-06 19:43 ` Pavel Machek
2004-06-08 23:07 ` Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®