From: Pavel Machek <pavel@ucw.cz>
To: Dominik Brodowski <linux@dominikbrodowski.de>,
john stultz <johnstul@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
george anzinger <george@mvista.com>, greg kh <greg@kroah.com>,
Chris McDermott <lcm@us.ibm.com>
Subject: Re: Too much error in __const_udelay() ?
Date: Sun, 6 Jun 2004 21:46:29 +0200 [thread overview]
Message-ID: <20040606194629.GB10081@elf.ucw.cz> (raw)
In-Reply-To: <20040605152326.GA11239@dominikbrodowski.de>
Hi!
> Change 3:
>
> Asserting at least 1 loop is spent: in really small ndelay() calls to
> low-mhz timers, this might be better.
>
> return __delay(xloops ? xloops : 1);
Should not you always round up? If user asks you to delay 1900 usec,
delaying 1000 usec is a bug. If you do this, make-it-one-when-its-zero
hack should be unneccessary.
Pavel
--
934a471f20d6580d5aad759bf0d97ddc
next prev parent reply other threads:[~2004-06-06 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-05 7:12 john stultz
2004-06-05 15:23 ` Dominik Brodowski
2004-06-06 19:46 ` Pavel Machek [this message]
2004-06-07 19:12 ` john stultz
2004-06-07 20:27 ` john stultz
2004-06-07 21:20 ` [PATCH 1/3] mull'ify multiplication with HZ in __const_udelay() [Was: Re: Too much error in __const_udelay() ?] Dominik Brodowski
2004-06-07 22:00 ` john stultz
2004-06-15 6:11 ` Dominik Brodowski
2004-06-07 21:22 ` [PATCH 2/3] round up in __udelay() " Dominik Brodowski
2004-06-07 21:23 ` [PATCH 3/3] fix for small xloops " Dominik Brodowski
2004-06-09 10:03 ` Pavel Machek
2004-06-07 21:23 ` Too much error in __const_udelay() ? Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040606194629.GB10081@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=george@mvista.com \
--cc=greg@kroah.com \
--cc=johnstul@us.ibm.com \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®