From: Dominik Brodowski <linux@dominikbrodowski.de>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
george anzinger <george@mvista.com>, greg kh <greg@kroah.com>,
Chris McDermott <lcm@us.ibm.com>
Subject: Re: Too much error in __const_udelay() ?
Date: Mon, 7 Jun 2004 23:23:48 +0200 [thread overview]
Message-ID: <20040607212348.GD23106@dominikbrodowski.de> (raw)
In-Reply-To: <1086635568.2234.171.camel@cog.beaverton.ibm.com>
On Mon, Jun 07, 2004 at 12:12:48PM -0700, john stultz wrote:
> I agree w/ Pavel that rounding up sounds better, but I can't get the
> math to work, so this may be the best solution.
It's some strange sort of rounding, see my patch "3"...
> I'm also spinning up a patch w/ these changes to test, let me know how
> your testing went and I'll do the same.
Testing went fine -- even for the PMTMR-based delay case [*].
Dominik
[*] though I noticed the cpufreq notifier breaks then: it updates
loops_per_jiffy without evaluating if it's indeed TSC- or even
frequency-based. It'll fail on cyclone, too, I think...
prev parent reply other threads:[~2004-06-07 21:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-05 7:12 john stultz
2004-06-05 15:23 ` Dominik Brodowski
2004-06-06 19:46 ` Pavel Machek
2004-06-07 19:12 ` john stultz
2004-06-07 20:27 ` john stultz
2004-06-07 21:20 ` [PATCH 1/3] mull'ify multiplication with HZ in __const_udelay() [Was: Re: Too much error in __const_udelay() ?] Dominik Brodowski
2004-06-07 22:00 ` john stultz
2004-06-15 6:11 ` Dominik Brodowski
2004-06-07 21:22 ` [PATCH 2/3] round up in __udelay() " Dominik Brodowski
2004-06-07 21:23 ` [PATCH 3/3] fix for small xloops " Dominik Brodowski
2004-06-09 10:03 ` Pavel Machek
2004-06-07 21:23 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040607212348.GD23106@dominikbrodowski.de \
--to=linux@dominikbrodowski.de \
--cc=george@mvista.com \
--cc=greg@kroah.com \
--cc=johnstul@us.ibm.com \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®