From: Andrew Morton <akpm@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, vince@kyllikki.org
Subject: Re: [VGA16FB] Fix bogus mem_start value
Date: Tue, 8 Jun 2004 03:09:06 -0700 [thread overview]
Message-ID: <20040608030906.0dd7d99f.akpm@osdl.org> (raw)
In-Reply-To: <20040608100530.GA26292@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> The recent change to vga16fb's memory mapping that you partially
> reverted is still broken. In particular, it's setting fix.mem_start
> to a virtual address on i386. The value of fix.mem_start is meant
> to be physical.
Sigh. Fiasco.
> We could simply apply virt_to_phys to it, but somehow I doubt that
> is what it's meant to do on arm. So until we hear from someone who
> knows how it works on arm, let's just revert this change.
Is this tested?
next prev parent reply other threads:[~2004-06-08 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 10:05 Herbert Xu
2004-06-08 10:09 ` Andrew Morton [this message]
2004-06-08 10:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040608030906.0dd7d99f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=vince@kyllikki.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®