[VGA16FB] Fix bogus mem_start value

[VGA16FB] Fix bogus mem_start value

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Hi Andrew:

The recent change to vga16fb's memory mapping that you partially
reverted is still broken.  In particular, it's setting fix.mem_start
to a virtual address on i386.  The value of fix.mem_start is meant
to be physical.

We could simply apply virt_to_phys to it, but somehow I doubt that
is what it's meant to do on arm.  So until we hear from someone who
knows how it works on arm, let's just revert this change.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 443 bytes --]

===== drivers/video/vga16fb.c 1.38 vs edited =====
--- 1.38/drivers/video/vga16fb.c	2004-05-22 18:18:20 +10:00
+++ edited/drivers/video/vga16fb.c	2004-06-08 19:57:40 +10:00
@@ -1372,8 +1372,6 @@
 	vga16fb.par = &vga16_par;
 	vga16fb.flags = FBINFO_FLAG_DEFAULT;
 
-	vga16fb.fix.smem_start	= VGA_MAP_MEM(vga16fb.fix.smem_start);
-
 	i = (vga16fb_defined.bits_per_pixel == 8) ? 256 : 16;
 	ret = fb_alloc_cmap(&vga16fb.cmap, i, 0);
 	if (ret) {

Re: [VGA16FB] Fix bogus mem_start value

[Andrew Morton]

Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> The recent change to vga16fb's memory mapping that you partially
>  reverted is still broken.  In particular, it's setting fix.mem_start
>  to a virtual address on i386.  The value of fix.mem_start is meant
>  to be physical.

Sigh.  Fiasco.

>  We could simply apply virt_to_phys to it, but somehow I doubt that
>  is what it's meant to do on arm.  So until we hear from someone who
>  knows how it works on arm, let's just revert this change.

Is this tested?

Re: [VGA16FB] Fix bogus mem_start value

[Herbert Xu]

On Tue, Jun 08, 2004 at 03:09:06AM -0700, Andrew Morton wrote:
> 
> >  We could simply apply virt_to_phys to it, but somehow I doubt that
> >  is what it's meant to do on arm.  So until we hear from someone who
> >  knows how it works on arm, let's just revert this change.
> 
> Is this tested?

Yes on i386.  It's also what what we've used since the beginning of
time until that change was introduced.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt