[STACK] weird code in some isdn drivers

[STACK] weird code in some isdn drivers

[Jörn Engel]

Karsten, Kai,

while I agree that this is a measurement bug, it's not exacly fun to
look at the code in question.  Can you please find a solution for
hscx_irq.c?

Either transform it into a header and uninline some of the longer
functions or make the functions global and add the necessary header
and Makefile-line.  In any case, I don't like to see something like
#include "hscx_irq.c"

stackframes for call path too long (268435490):
    size  function
       0  IsdnCardState->irq_func
268435466  teles3_interrupt
      24  hscx_empty_fifo
       0  read_fifo
       0  insb

Jörn

-- 
People will accept your ideas much more readily if you tell them
that Benjamin Franklin said it first.
-- unknown

Re: [STACK] weird code in some isdn drivers

[Karsten Keil]

On Wed, Jun 09, 2004 at 02:36:33PM +0200, Jörn Engel wrote:
> Karsten, Kai,
> 
> while I agree that this is a measurement bug, it's not exacly fun to
> look at the code in question.  Can you please find a solution for
> hscx_irq.c?

HiSax and I4L is in bugfix only mode, since it will replaced
by other drivers. So I do not want waste time for soon obsolate code.

> 
> Either transform it into a header and uninline some of the longer
> functions or make the functions global and add the necessary header
> and Makefile-line.  In any case, I don't like to see something like
> #include "hscx_irq.c"
> 

Yes I agree that it looks ugly and make not much more sense with today
CPUs and compilers. In the beginning of the development (on 386/486) and
with early GCC (inline was often broken) it did and reduced some
ping times so far I remember. (~1997)

> stackframes for call path too long (268435490):
>     size  function
>        0  IsdnCardState->irq_func
> 268435466  teles3_interrupt
>       24  hscx_empty_fifo
>        0  read_fifo
>        0  insb
> 
> Jörn
> 
> -- 
> People will accept your ideas much more readily if you tell them
> that Benjamin Franklin said it first.
> -- unknown

-- 
Karsten Keil
SuSE Labs
ISDN development

Re: [STACK] weird code in some isdn drivers

[Jörn Engel]

On Wed, 9 June 2004 15:16:28 +0200, Karsten Keil wrote:
> On Wed, Jun 09, 2004 at 02:36:33PM +0200, Jörn Engel wrote:
> > Karsten, Kai,
> > 
> > while I agree that this is a measurement bug, it's not exacly fun to
> > look at the code in question.  Can you please find a solution for
> > hscx_irq.c?
> 
> HiSax and I4L is in bugfix only mode, since it will replaced
> by other drivers. So I do not want waste time for soon obsolate code.

Valid solution.  Any date as to when the new drivers will be
available?

Jörn

-- 
To my face you have the audacity to advise me to become a thief - the worst
kind of thief that is conceivable, a thief of spiritual things, a thief of
ideas! It is insufferable, intolerable!
-- M. Binet in Scarabouche

Re: [STACK] weird code in some isdn drivers

[Karsten Keil]

On Wed, Jun 09, 2004 at 03:30:03PM +0200, Jörn Engel wrote:
> On Wed, 9 June 2004 15:16:28 +0200, Karsten Keil wrote:
> > On Wed, Jun 09, 2004 at 02:36:33PM +0200, Jörn Engel wrote:
> > > Karsten, Kai,
> > > 
> > > while I agree that this is a measurement bug, it's not exacly fun to
> > > look at the code in question.  Can you please find a solution for
> > > hscx_irq.c?
> > 
> > HiSax and I4L is in bugfix only mode, since it will replaced
> > by other drivers. So I do not want waste time for soon obsolate code.
> 
> Valid solution.  Any date as to when the new drivers will be
> available?
> 

I hope that I have enough time to fix the known issues in mISDN this month
and implement some more hardware, after this it should go into mainline.

-- 
Karsten Keil
SuSE Labs
ISDN development