* [PATCH][2.6.7-rc3-mm1] CPU_MASK_NONE fix
@ 2004-06-09 20:49 Mikael Pettersson
2004-06-09 22:29 ` Paul Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2004-06-09 20:49 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, pj
2.6.7-rc3-mm1 changed CPU_MASK_NONE into something that isn't
a valid rvalue (it only works inside struct initializers).
This caused compile-time errors in perfctr in UP x86 builds.
Fix below.
Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se>
diff -ruN linux-2.6.7-rc3-mm1/include/linux/cpumask.h linux-2.6.7-rc3-mm1.cpu_mask_none-fix/include/linux/cpumask.h
--- linux-2.6.7-rc3-mm1/include/linux/cpumask.h 2004-06-09 19:38:39.000000000 +0200
+++ linux-2.6.7-rc3-mm1.cpu_mask_none-fix/include/linux/cpumask.h 2004-06-09 22:01:28.470416000 +0200
@@ -248,9 +248,9 @@
#endif
#define CPU_MASK_NONE \
-{ { \
+((cpumask_t) { { \
[0 ... BITS_TO_LONGS(NR_CPUS)-1] = 0UL \
-} }
+} })
#define cpus_addr(src) ((src).bits)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][2.6.7-rc3-mm1] CPU_MASK_NONE fix
2004-06-09 20:49 [PATCH][2.6.7-rc3-mm1] CPU_MASK_NONE fix Mikael Pettersson
@ 2004-06-09 22:29 ` Paul Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Paul Jackson @ 2004-06-09 22:29 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: akpm, linux-kernel
Maikael wrote:
> 2.6.7-rc3-mm1 changed CPU_MASK_NONE into something that isn't
I believe that Bill Irwin also snuck this fix into his irqaction->mask
patch, posted Wed, 9 Jun 2004 10:59:10 -0700.
Thanks, Bill and Mikael, for your fixes to the dreaded -;) cpumask patch.
Thanks, Andrew, for including it.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-09 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-09 20:49 [PATCH][2.6.7-rc3-mm1] CPU_MASK_NONE fix Mikael Pettersson
2004-06-09 22:29 ` Paul Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®