[HPT366] Fix /proc/ide/hpt366 crash

[HPT366] Fix /proc/ide/hpt366 crash

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi Marcelo:

The following patch which fixes fixes the disk spindown problem when
/proc/ide/hpt366 is read has been in 2.6 for a couple of months.  It
has just been verified that the same fix is needed and works under
2.4 (see http://bugs.debian.org/250171).

So please apply it.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 656 bytes --]

===== drivers/ide/pci/hpt366.c 1.14 vs edited =====
--- 1.14/drivers/ide/pci/hpt366.c	2004-05-01 08:27:08 +10:00
+++ edited/drivers/ide/pci/hpt366.c	2004-06-09 21:20:01 +10:00
@@ -123,7 +123,7 @@
 				"                             %s\n",
 			(c0 & 0x80) ? "no" : "yes",
 			(c1 & 0x80) ? "no" : "yes");
-
+#if 0
 		if (hpt_minimum_revision(dev, 3)) {
 			u8 cbl;
 			cbl = inb(iobase + 0x7b);
@@ -136,7 +136,7 @@
 				(cbl & 0x01) ? 33 : 66);
 			p += sprintf(p, "\n");
 		}
-
+#endif
 		p += sprintf(p, "--------------- drive0 --------- drive1 "
 				"------- drive0 ---------- drive1 -------\n");
 		p += sprintf(p, "DMA capable:    %s              %s" 

Re: [HPT366] Fix /proc/ide/hpt366 crash

[Marcelo Tosatti]

On Wed, Jun 09, 2004 at 09:20:25PM +1000, Herbert Xu wrote:
> Hi Marcelo:
> 
> The following patch which fixes fixes the disk spindown problem when
> /proc/ide/hpt366 is read has been in 2.6 for a couple of months.  It
> has just been verified that the same fix is needed and works under
> 2.4 (see http://bugs.debian.org/250171).

Applied, thanks Herbert.