mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: akpm@osdl.org, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, Mika Kukkonen <mika@osdl.org>
Subject: [PATCH 1/3] __user annotation for shm_shmat hook declaration
Date: Mon, 14 Jun 2004 09:23:43 -0700	[thread overview]
Message-ID: <20040614092343.A21045@build.pdx.osdl.net> (raw)

Add proper __user annotation for shm_shmat hook in security.h.

  CHECK   ipc/shm.c
include/linux/security.h:1831:38: warning: incorrect type in argument 2 (different address spaces)
include/linux/security.h:1831:38:    expected char *shmaddr
include/linux/security.h:1831:38:    got char [noderef] *shmaddr<asn:1>
  CC      ipc/shm.o

From: Mika Kukkonen <mika@osdl.org>
Signed-off-by: Chris Wright <chrisw@osdl.org>

===== include/linux/security.h 1.34 vs edited =====
--- 1.34/include/linux/security.h	2004-05-08 15:00:18 -07:00
+++ edited/include/linux/security.h	2004-06-14 08:56:50 -07:00
@@ -1172,7 +1172,7 @@
 	int (*shm_associate) (struct shmid_kernel * shp, int shmflg);
 	int (*shm_shmctl) (struct shmid_kernel * shp, int cmd);
 	int (*shm_shmat) (struct shmid_kernel * shp, 
-			  char *shmaddr, int shmflg);
+			  char __user *shmaddr, int shmflg);
 
 	int (*sem_alloc_security) (struct sem_array * sma);
 	void (*sem_free_security) (struct sem_array * sma);

             reply	other threads:[~2004-06-14 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-14 16:23 Chris Wright [this message]
2004-06-14 16:27 ` [PATCH 2/3] __user annotation for selinux_shm_shmat Chris Wright
2004-06-14 16:29   ` [PATCH 3/3] __user annotation for dummy_shm_shmat Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040614092343.A21045@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika@osdl.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®