mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: akpm@osdl.org, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, Mika Kukkonen <mika@osdl.org>,
	sds@epoch.ncsc.mil, jmorris@redhat.com
Subject: [PATCH 2/3] __user annotation for selinux_shm_shmat
Date: Mon, 14 Jun 2004 09:27:56 -0700	[thread overview]
Message-ID: <20040614092756.B21045@build.pdx.osdl.net> (raw)
In-Reply-To: <20040614092343.A21045@build.pdx.osdl.net>; from chrisw@osdl.org on Mon, Jun 14, 2004 at 09:23:43AM -0700

Add proper __user annotation to selinux_shm_shmat.

  CHECK   security/selinux/hooks.c
security/selinux/hooks.c:4163:17: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
security/selinux/hooks.c:4163:17:    expected int ( *shm_shmat )( ... )
security/selinux/hooks.c:4163:17:    got int ( static [addressable] [toplevel] *<noident> )( ... )
  CC      security/selinux/hooks.o

From: Mika Kukkonen <mika@osdl.org>
Signed-off-by: Chris Wright <chrisw@osdl.org>

===== security/selinux/hooks.c 1.41 vs edited =====
--- 1.41/security/selinux/hooks.c	2004-06-12 20:52:29 -07:00
+++ edited/security/selinux/hooks.c	2004-06-14 09:00:37 -07:00
@@ -3781,7 +3781,7 @@
 }
 
 static int selinux_shm_shmat(struct shmid_kernel *shp,
-			     char *shmaddr, int shmflg)
+			     char __user *shmaddr, int shmflg)
 {
 	u32 perms;
 

  reply	other threads:[~2004-06-14 16:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-14 16:23 [PATCH 1/3] __user annotation for shm_shmat hook declaration Chris Wright
2004-06-14 16:27 ` Chris Wright [this message]
2004-06-14 16:29   ` [PATCH 3/3] __user annotation for dummy_shm_shmat Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040614092756.B21045@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=jmorris@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika@osdl.org \
    --cc=sds@epoch.ncsc.mil \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®