From: Sam Ravnborg <sam@ravnborg.org>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Martin Schlemmer <azarah@nosferatu.za.org>,
Linux Kernel Mailing Lists <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] kbuild updates
Date: Tue, 22 Jun 2004 01:03:21 +0200 [thread overview]
Message-ID: <20040621230321.GI2903@mars.ravnborg.org> (raw)
In-Reply-To: <200406220050.09791.agruen@suse.de>
On Tue, Jun 22, 2004 at 12:50:09AM +0200, Andreas Gruenbacher wrote:
> On Tuesday 22 June 2004 00:31, Sam Ravnborg wrote:
> > But Martin has a point here.
>
> Yes.
>
> > Other modules uses the grep method - which will fail when the kernel
> > is build with separate output and source directories.
>
> Is there anything fundamentally wrong with invoking the test script from
> within the module makefile, when really necessary? This doesn't work very
> well if you need the test results outside of the module build.
>
> ----- Makefile -----
> test_result := $(shell ...)
> ifneq ($(test_result),)
> EXTRA_CFLAGS := -DSOMETHING
> endif
> ...
> -------- 8< --------
I like keeping the kbuild makefile clean as such - but otherwise not.
One has to secure that right CFLAGS etc is used though.
Also when make -j N is used one has to be very carefully with prerequisites - as always.
Sam
next prev parent reply other threads:[~2004-06-21 22:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-20 21:19 Sam Ravnborg
2004-06-20 21:21 ` [PATCH 1/2] kbuil: add deb-pkg target Sam Ravnborg
2004-06-20 21:22 ` [PATCH 0/2] kbuild updates Sam Ravnborg
2004-06-20 21:23 ` [PATCH 2/2] kbuild: Improved external module support Sam Ravnborg
2004-06-20 21:25 ` Arjan van de Ven
2004-06-20 21:31 ` Martin Schlemmer
2004-06-20 21:45 ` Sam Ravnborg
2004-06-20 21:38 ` Arjan van de Ven
2004-06-21 1:41 ` Petr Vandrovec
2004-06-21 9:01 ` Geert Uytterhoeven
2004-06-21 21:57 ` Sam Ravnborg
2004-06-20 21:30 ` [PATCH 0/2] kbuild updates Martin Schlemmer
2004-06-20 21:42 ` Arjan van de Ven
2004-06-20 21:52 ` Martin Schlemmer
2004-06-20 22:26 ` Andreas Gruenbacher
2004-06-20 22:39 ` Martin Schlemmer
2004-06-20 23:51 ` Andreas Gruenbacher
2004-06-21 22:31 ` Sam Ravnborg
2004-06-21 22:33 ` Martin Schlemmer
2004-06-21 22:50 ` Andreas Gruenbacher
2004-06-21 23:03 ` Sam Ravnborg [this message]
2004-06-20 22:03 ` Sam Ravnborg
2004-06-20 22:16 ` Martin Schlemmer
2004-06-20 22:26 ` Alistair John Strachan
2004-06-20 22:54 ` Martin Schlemmer
2004-06-21 22:46 ` Sam Ravnborg
2004-06-21 22:33 ` Sam Ravnborg
2004-06-21 22:29 ` Martin Schlemmer
2004-06-21 22:56 ` Andreas Gruenbacher
2004-06-20 22:18 ` Sam Ravnborg
2004-06-20 22:25 ` Martin Schlemmer
2004-06-21 22:48 ` Sam Ravnborg
2004-06-22 5:29 ` Jari Ruusu
2004-06-22 9:20 ` Andreas Gruenbacher
2004-06-22 18:23 ` Jari Ruusu
2004-06-22 18:44 ` Sam Ravnborg
2004-06-21 0:29 ` Hannu Savolainen
2004-06-21 1:27 ` Andreas Gruenbacher
2004-06-21 6:47 ` Arjan van de Ven
2004-06-21 8:02 ` Hannu Savolainen
[not found] <29hJN-3Jl-35@gated-at.bofh.it>
[not found] ` <29icN-42R-13@gated-at.bofh.it>
[not found] ` <29imu-4ad-31@gated-at.bofh.it>
[not found] ` <29iwc-4g7-27@gated-at.bofh.it>
2004-06-20 22:36 ` Pascal Schmidt
[not found] <539000871@toto.iv>
2004-06-22 1:39 ` Peter Chubb
2004-06-22 5:20 ` Sam Ravnborg
2004-06-22 8:36 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040621230321.GI2903@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=agruen@suse.de \
--cc=azarah@nosferatu.za.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®