mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Prepare for SMP suspend
@ 2004-06-23 12:27 Pavel Machek
  0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2004-06-23 12:27 UTC (permalink / raw)
  To: Andrew Morton, kernel list

Hi!

Its very bad idea to freeze migration threads, as it crashes machine
upon next call to "schedule()". In refrigerator, I had one
"wake_up_process()" too many. This fixes it. Please apply,

Signed-off-by: Pavel Machek <pavel@suse.cz>

								Pavel

--- clean/kernel/sched.c	2004-06-22 12:36:47.000000000 +0200
+++ linux/kernel/sched.c	2004-06-22 12:39:00.000000000 +0200
@@ -3558,6 +3558,7 @@
 		p = kthread_create(migration_thread, hcpu, "migration/%d",cpu);
 		if (IS_ERR(p))
 			return NOTIFY_BAD;
+		p->flags |= PF_NOFREEZE;
 		kthread_bind(p, cpu);
 		/* Must be high prio: stop_machine expects to yield to it. */
 		rq = task_rq_lock(p, &flags);
 
--- linux.orig/kernel/power/process.c	2004-06-22 12:53:19.000000000 +0200
+++ linux/kernel/power/process.c	2004-06-03 00:27:56.000000000 +0200
@@ -109,7 +109,6 @@
 			wake_up_process(p);
 		} else
 			printk(KERN_INFO " Strange, %s not stopped\n", p->comm );
-		wake_up_process(p);
 	} while_each_thread(g, p);
 
 	read_unlock(&tasklist_lock);

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-06-23 12:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-23 12:27 Prepare for SMP suspend Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®