* swsusp: kill useless exports
@ 2004-06-25 11:56 Pavel Machek
2004-06-26 23:08 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2004-06-25 11:56 UTC (permalink / raw)
To: Andrew Morton, kernel list, Patrick Mochel,
Rusty trivial patch monkey Russell
Hi!
These exports seem totally unneccessary as swsusp can't be module
anyway. Idea by Patrick Mochel. Please apply,
Pavel
--- linux-cvs//arch/i386/power/cpu.c 2004-06-25 13:08:23.000000000 +0200
+++ linux/arch/i386/power/cpu.c 2004-06-24 23:37:00.000000000 +0200
@@ -147,7 +147,3 @@
{
__restore_processor_state(&saved_context);
}
-
-
-EXPORT_SYMBOL(save_processor_state);
-EXPORT_SYMBOL(restore_processor_state);
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: swsusp: kill useless exports
2004-06-25 11:56 swsusp: kill useless exports Pavel Machek
@ 2004-06-26 23:08 ` Andrew Morton
2004-06-27 8:51 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2004-06-26 23:08 UTC (permalink / raw)
To: Pavel Machek; +Cc: linux-kernel, mochel, trivial
Pavel Machek <pavel@ucw.cz> wrote:
>
> Hi!
>
> These exports seem totally unneccessary as swsusp can't be module
> anyway. Idea by Patrick Mochel. Please apply,
> Pavel
>
> --- linux-cvs//arch/i386/power/cpu.c 2004-06-25 13:08:23.000000000 +0200
> +++ linux/arch/i386/power/cpu.c 2004-06-24 23:37:00.000000000 +0200
> @@ -147,7 +147,3 @@
> {
> __restore_processor_state(&saved_context);
> }
> -
> -
> -EXPORT_SYMBOL(save_processor_state);
> -EXPORT_SYMBOL(restore_processor_state);
These are called from apm.c, which can be built as a module.
(grep!)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: swsusp: kill useless exports
2004-06-26 23:08 ` Andrew Morton
@ 2004-06-27 8:51 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2004-06-27 8:51 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, mochel, trivial
Hi!
> > These exports seem totally unneccessary as swsusp can't be module
> > anyway. Idea by Patrick Mochel. Please apply,
> > Pavel
> >
> > --- linux-cvs//arch/i386/power/cpu.c 2004-06-25 13:08:23.000000000 +0200
> > +++ linux/arch/i386/power/cpu.c 2004-06-24 23:37:00.000000000 +0200
> > @@ -147,7 +147,3 @@
> > {
> > __restore_processor_state(&saved_context);
> > }
> > -
> > -
> > -EXPORT_SYMBOL(save_processor_state);
> > -EXPORT_SYMBOL(restore_processor_state);
>
> These are called from apm.c, which can be built as a module.
>
> (grep!)
Ouch, sorry about that, I'll add a comment so this "cleanup" does not came
up in future.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-06-27 8:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-25 11:56 swsusp: kill useless exports Pavel Machek
2004-06-26 23:08 ` Andrew Morton
2004-06-27 8:51 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®