* nfsroot oops 2.6.7-current
@ 2004-06-28 17:38 Andre Noll
2004-06-28 17:53 ` Trond Myklebust
2004-06-28 17:59 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Andre Noll @ 2004-06-28 17:38 UTC (permalink / raw)
To: linux-kernel
Hi
Al's current changes to struct nameidata broke nfsroot for my discless
clients (oops in nfs_fill_super). The patch below fixes this problem
for me.
Andre
diff -u -r1.19 rpc_pipe.c
--- linux-2.5/net/sunrpc/rpc_pipe.c 31 May 2004 03:06:56 -0000 1.19
+++ linux-2.5/net/sunrpc/rpc_pipe.c 28 Jun 2004 17:10:51 -0000
@@ -433,6 +433,7 @@
nd->dentry = dget(rpc_mount->mnt_root);
nd->last_type = LAST_ROOT;
nd->flags = LOOKUP_PARENT;
+ nd->depth = 0;
if (path_walk(path, nd)) {
printk(KERN_WARNING "%s: %s failed to find path %s\n",
--
Andre Noll, http://www.mathematik.tu-darmstadt.de/~noll
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: nfsroot oops 2.6.7-current
2004-06-28 17:38 nfsroot oops 2.6.7-current Andre Noll
@ 2004-06-28 17:53 ` Trond Myklebust
2004-06-28 19:11 ` viro
2004-06-28 17:59 ` Andrew Morton
1 sibling, 1 reply; 4+ messages in thread
From: Trond Myklebust @ 2004-06-28 17:53 UTC (permalink / raw)
To: Andre Noll, Alexander Viro; +Cc: linux-kernel
Yep, and there's probably one missing in fs/nfsctl.c:do_open() too. Al?
Cheers,
Trond
På må , 28/06/2004 klokka 13:38, skreiv Andre Noll:
> Hi
>
> Al's current changes to struct nameidata broke nfsroot for my discless
> clients (oops in nfs_fill_super). The patch below fixes this problem
> for me.
>
> Andre
>
> diff -u -r1.19 rpc_pipe.c
> --- linux-2.5/net/sunrpc/rpc_pipe.c 31 May 2004 03:06:56 -0000 1.19
> +++ linux-2.5/net/sunrpc/rpc_pipe.c 28 Jun 2004 17:10:51 -0000
> @@ -433,6 +433,7 @@
> nd->dentry = dget(rpc_mount->mnt_root);
> nd->last_type = LAST_ROOT;
> nd->flags = LOOKUP_PARENT;
> + nd->depth = 0;
>
> if (path_walk(path, nd)) {
> printk(KERN_WARNING "%s: %s failed to find path %s\n",
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: nfsroot oops 2.6.7-current
2004-06-28 17:38 nfsroot oops 2.6.7-current Andre Noll
2004-06-28 17:53 ` Trond Myklebust
@ 2004-06-28 17:59 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2004-06-28 17:59 UTC (permalink / raw)
To: Andre Noll; +Cc: linux-kernel
Andre Noll <noll@mathematik.tu-darmstadt.de> wrote:
>
> --- linux-2.5/net/sunrpc/rpc_pipe.c 31 May 2004 03:06:56 -0000 1.19
> +++ linux-2.5/net/sunrpc/rpc_pipe.c 28 Jun 2004 17:10:51 -0000
> @@ -433,6 +433,7 @@
> nd->dentry = dget(rpc_mount->mnt_root);
> nd->last_type = LAST_ROOT;
> nd->flags = LOOKUP_PARENT;
> + nd->depth = 0;
Neat, thanks. Quite a few people have been hitting that.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: nfsroot oops 2.6.7-current
2004-06-28 17:53 ` Trond Myklebust
@ 2004-06-28 19:11 ` viro
0 siblings, 0 replies; 4+ messages in thread
From: viro @ 2004-06-28 19:11 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Andre Noll, linux-kernel
On Mon, Jun 28, 2004 at 01:53:13PM -0400, Trond Myklebust wrote:
> Yep, and there's probably one missing in fs/nfsctl.c:do_open() too. Al?
ACK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-06-28 19:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-28 17:38 nfsroot oops 2.6.7-current Andre Noll
2004-06-28 17:53 ` Trond Myklebust
2004-06-28 19:11 ` viro
2004-06-28 17:59 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®