* MTRR __initdata confusion.
@ 2004-07-03 16:41 Dave Jones
2004-07-03 16:53 ` Randy.Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2004-07-03 16:41 UTC (permalink / raw)
To: Linux Kernel; +Cc: Andrew Morton
smp_changes_mask is used by generic_set_all() which isn't __init
Signed-off-by: Dave Jones <davej@redhat.com>
Dave
--- FC2/arch/i386/kernel/cpu/mtrr/generic.c~ 2004-07-03 17:40:00.408094696 +0100
+++ FC2/arch/i386/kernel/cpu/mtrr/generic.c 2004-07-03 17:40:05.666295328 +0100
@@ -18,7 +18,7 @@
mtrr_type def_type;
};
-static unsigned long smp_changes_mask __initdata = 0;
+static unsigned long smp_changes_mask = 0;
struct mtrr_state mtrr_state = {};
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: MTRR __initdata confusion.
2004-07-03 16:41 MTRR __initdata confusion Dave Jones
@ 2004-07-03 16:53 ` Randy.Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy.Dunlap @ 2004-07-03 16:53 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel, akpm
On Sat, 3 Jul 2004 17:41:43 +0100 Dave Jones wrote:
| smp_changes_mask is used by generic_set_all() which isn't __init
|
| Signed-off-by: Dave Jones <davej@redhat.com>
|
| Dave
|
| --- FC2/arch/i386/kernel/cpu/mtrr/generic.c~ 2004-07-03 17:40:00.408094696 +0100
| +++ FC2/arch/i386/kernel/cpu/mtrr/generic.c 2004-07-03 17:40:05.666295328 +0100
| @@ -18,7 +18,7 @@
| mtrr_type def_type;
| };
|
| -static unsigned long smp_changes_mask __initdata = 0;
| +static unsigned long smp_changes_mask = 0;
| struct mtrr_state mtrr_state = {};
"= 0" can be dropped, as in the patch that I posted abour 2 weeks back:
http://marc.theaimsgroup.com/?l=linux-kernel&m=108727726300903&w=2
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-03 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-03 16:41 MTRR __initdata confusion Dave Jones
2004-07-03 16:53 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®