From: Andrew Morton <akpm@osdl.org>
To: "R. J. Wysocki" <rjwysocki@sisk.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.7-mm6: system hang with KAMix on dual Opteron w/ NUMA
Date: Thu, 8 Jul 2004 14:21:53 -0700 [thread overview]
Message-ID: <20040708142153.60c2cb69.akpm@osdl.org> (raw)
In-Reply-To: <200407082324.55181.rjwysocki@sisk.pl>
"R. J. Wysocki" <rjwysocki@sisk.pl> wrote:
>
> I've just discovered that I'm (consistently) able to hang the system solid by
> trying to adjust the sound volume using KAMix on 2.6.7-mm6 (SuSE 9.1/ AMD64).
Please ensure that your kernel has this patch:
--- 25/sound/core/control.c~snd_ctl_read-locking-fix-fix 2004-07-06 21:27:51.618683360 -0700
+++ 25-akpm/sound/core/control.c 2004-07-06 21:27:51.622682752 -0700
@@ -1116,7 +1116,7 @@ static ssize_t snd_ctl_read(struct file
wait_queue_t wait;
if ((file->f_flags & O_NONBLOCK) != 0 || result > 0) {
err = -EAGAIN;
- goto out;
+ goto __end;
}
init_waitqueue_entry(&wait, current);
add_wait_queue(&ctl->change_sleep, &wait);
@@ -1137,7 +1137,7 @@ static ssize_t snd_ctl_read(struct file
kfree(kev);
if (copy_to_user(buffer, &ev, sizeof(snd_ctl_event_t))) {
err = -EFAULT;
- goto __end;
+ goto out;
}
spin_lock_irq(&ctl->read_lock);
buffer += sizeof(snd_ctl_event_t);
_
next prev parent reply other threads:[~2004-07-08 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-08 21:24 R. J. Wysocki
2004-07-08 21:21 ` Andrew Morton [this message]
2004-07-08 21:50 ` R. J. Wysocki
2004-07-08 21:26 ` R. J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040708142153.60c2cb69.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjwysocki@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®