From: Bill Nottingham <notting@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: breed@users.sourceforge.net, fabrice@bellet.info
Subject: [PATCH] fix airo oops-on-removal
Date: Thu, 8 Jul 2004 17:31:51 -0400 [thread overview]
Message-ID: <20040708213151.GE13918@nostromo.devel.redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
airo creates /proc/driver/aironet/<device name> on device activation.
However, the device can be renamed - then on teardown
it tries to remove the wrong directory. The removal of
/proc/driver/aironet then runs afoul of the BUG_ON() in remove_proc_entry.
This fixes it by keeping a copy of the name of the directory
it created.
(It doesn't actually solve the problem of the stats directory
still being /proc/driver/aironet/eth0 when you rename the device
to, say, 'joe'. But that patch would be a little less trivial.)
Bill
[-- Attachment #2: airo.patch --]
[-- Type: text/plain, Size: 1047 bytes --]
--- linux/drivers/net/wireless/airo.c.old 2004-07-08 17:19:37.856055132 -0400
+++ linux/drivers/net/wireless/airo.c 2004-07-08 17:28:26.720339699 -0400
@@ -1210,6 +1210,7 @@
APListRid *APList;
#define PCI_SHARED_LEN 2*MPI_MAX_FIDS*PKTSIZE+RIDSIZE
u32 pci_state[16];
+ char proc_name[IFNAMSIZ];
};
static inline int bap_read(struct airo_info *ai, u16 *pu16Dst, int bytelen,
@@ -4369,7 +4370,8 @@
struct airo_info *apriv ) {
struct proc_dir_entry *entry;
/* First setup the device directory */
- apriv->proc_entry = create_proc_entry(dev->name,
+ strcpy(apriv->proc_name,dev->name);
+ apriv->proc_entry = create_proc_entry(apriv->proc_name,
S_IFDIR|airo_perm,
airo_entry);
apriv->proc_entry->uid = proc_uid;
@@ -4472,7 +4474,7 @@
remove_proc_entry("APList",apriv->proc_entry);
remove_proc_entry("BSSList",apriv->proc_entry);
remove_proc_entry("WepKey",apriv->proc_entry);
- remove_proc_entry(dev->name,airo_entry);
+ remove_proc_entry(apriv->proc_name,airo_entry);
return 0;
}
next reply other threads:[~2004-07-08 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-08 21:31 Bill Nottingham [this message]
2004-07-08 21:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040708213151.GE13918@nostromo.devel.redhat.com \
--to=notting@redhat.com \
--cc=breed@users.sourceforge.net \
--cc=fabrice@bellet.info \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®