From: Christoph Hellwig <hch@infradead.org>
To: linux-kernel@vger.kernel.org, breed@users.sourceforge.net,
fabrice@bellet.info
Subject: Re: [PATCH] fix airo oops-on-removal
Date: Thu, 8 Jul 2004 22:34:20 +0100 [thread overview]
Message-ID: <20040708213420.GA19036@infradead.org> (raw)
In-Reply-To: <20040708213151.GE13918@nostromo.devel.redhat.com>
On Thu, Jul 08, 2004 at 05:31:51PM -0400, Bill Nottingham wrote:
> airo creates /proc/driver/aironet/<device name> on device activation.
> However, the device can be renamed - then on teardown
> it tries to remove the wrong directory. The removal of
> /proc/driver/aironet then runs afoul of the BUG_ON() in remove_proc_entry.
>
> This fixes it by keeping a copy of the name of the directory
> it created.
>
> (It doesn't actually solve the problem of the stats directory
> still being /proc/driver/aironet/eth0 when you rename the device
> to, say, 'joe'. But that patch would be a little less trivial.)
Still sounds like a rather broken behaviour. We should probably
nuke that whole procfs interface thingy instead.
prev parent reply other threads:[~2004-07-08 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-08 21:31 Bill Nottingham
2004-07-08 21:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040708213420.GA19036@infradead.org \
--to=hch@infradead.org \
--cc=breed@users.sourceforge.net \
--cc=fabrice@bellet.info \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®