From: Andrew Morton <akpm@osdl.org>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Instrumenting high latency
Date: Sun, 11 Jul 2004 23:58:46 -0700 [thread overview]
Message-ID: <20040711235846.35004c45.akpm@osdl.org> (raw)
In-Reply-To: <cone.1089614621.957671.28499.502@pc.kolivas.org>
Con Kolivas <kernel@kolivas.org> wrote:
>
> It can trip
> over itself saying that it's own code paths are a problem too if it gets
> real busy.
This might fix it?
diff -puN arch/i386/kernel/traps.c~instrumenting-high-latency-fixes arch/i386/kernel/traps.c
--- 25/arch/i386/kernel/traps.c~instrumenting-high-latency-fixes 2004-07-11 23:47:51.007799680 -0700
+++ 25-akpm/arch/i386/kernel/traps.c 2004-07-11 23:57:58.726412408 -0700
@@ -1065,6 +1065,9 @@ void __dec_preempt_count(void)
if (preempt_count() == 1 && system_state == SYSTEM_RUNNING &&
__get_cpu_var(preempt_entry)) {
u64 exit;
+
+ preempt_count()++; /* Prevent recursive warnings */
+
__get_cpu_var(preempt_exit)
= (unsigned long)__builtin_return_address(0);
rdtscll(exit);
@@ -1082,12 +1085,13 @@ void __dec_preempt_count(void)
preempt_thresh);
print_symbol("%s and ending at ",
__get_cpu_var(preempt_entry));
- print_symbol("%s\n",
- __get_cpu_var(preempt_exit));
+ print_symbol("%s", __get_cpu_var(preempt_exit));
+ printk("\n");
dump_stack();
}
}
__get_cpu_var(preempt_exit) = __get_cpu_var(preempt_entry) = 0;
+ preempt_count()--;
}
preempt_count()--;
}
_
next prev parent reply other threads:[~2004-07-12 7:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-12 6:29 [PATCH] " Con Kolivas
2004-07-12 6:37 ` Andrew Morton
2004-07-12 6:43 ` Con Kolivas
2004-07-12 6:58 ` Andrew Morton [this message]
2004-07-12 7:00 ` [PATCH] " William Lee Irwin III
2004-07-12 7:34 ` Andrew Morton
2004-07-12 8:02 ` William Lee Irwin III
2004-07-12 8:38 ` William Lee Irwin III
2004-07-12 11:31 ` William Lee Irwin III
2004-07-12 14:32 ` William Lee Irwin III
2004-07-12 17:09 ` Martin Josefsson
2004-07-12 8:29 ` Arjan van de Ven
2004-07-12 8:42 ` William Lee Irwin III
2004-07-12 8:47 ` William Lee Irwin III
2004-07-12 10:41 ` Rajput
2004-07-12 10:44 ` William Lee Irwin III
2004-07-12 14:24 ` Martin J. Bligh
2004-07-12 14:27 ` Con Kolivas
2004-07-12 14:33 ` Martin J. Bligh
2004-07-12 14:42 ` Con Kolivas
2004-07-12 14:47 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040711235846.35004c45.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®