From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, sam@ravnborg.org,
Patrick Mochel <mochel@digitalimplant.org>,
Andrew Morton <akpm@zip.com.au>
Subject: Re: [0/25] Merge pmdisk and swsusp
Date: Tue, 20 Jul 2004 21:21:24 +0200 [thread overview]
Message-ID: <20040720192123.GA9461@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <200407201241.52334.dtor_core@ameritech.net>
Hi!
> > > diff -ur linux.middle/kernel/power/disk.c linux/kernel/power/disk.c
> > > --- linux.middle/kernel/power/disk.c 2004-07-19 08:58:08.000000000 -0700
> > > +++ linux/kernel/power/disk.c 2004-07-19 15:00:16.000000000 -0700
> > > @@ -63,6 +63,9 @@
> > > break;
> > > }
> > > machine_halt();
> > > + /* Valid image is on the disk, if we continue we risk serious data corruption
> > > + after resume. */
> > > + while(1);
> >
> > Would be nicer to use:
> >
> > while(1)
> > /* Loop forever */;
> >
> > Sam
>
> And even nicer would be remove swsusp signature from swap and restore state as
> original version did so user could do clean shutdown...
Actually, at this point you are expected to just power down, and what
you wanted is done: machine is suspended to disk.
No need to kill signature and make swsusp unusable when powerdown does
not work.
Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.
next prev parent reply other threads:[~2004-07-20 19:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-17 22:34 Patrick Mochel
2004-07-18 22:04 ` Pavel Machek
2004-07-18 22:04 ` Nigel Cunningham
2004-07-19 1:24 ` Andrew Morton
2004-07-18 22:27 ` Pavel Machek
2004-08-02 5:13 ` Patrick Mochel
2004-07-20 16:46 ` Pavel Machek
2004-07-20 19:28 ` sam
2004-07-20 17:41 ` Dmitry Torokhov
2004-07-20 19:21 ` Pavel Machek [this message]
2004-08-02 5:42 ` Patrick Mochel
2004-08-06 19:43 ` Pavel Machek
2004-07-27 7:17 ` Felipe Alfaro Solana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040720192123.GA9461@atrey.karlin.mff.cuni.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®