From: sam@ravnborg.org
To: Pavel Machek <pavel@suse.cz>
Cc: Patrick Mochel <mochel@digitalimplant.org>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@zip.com.au>
Subject: Re: [0/25] Merge pmdisk and swsusp
Date: Tue, 20 Jul 2004 21:28:58 +0200 [thread overview]
Message-ID: <20040720192858.GB9147@mars.ravnborg.org> (raw)
In-Reply-To: <20040720164640.GH10921@atrey.karlin.mff.cuni.cz>
On Tue, Jul 20, 2004 at 06:46:40PM +0200, Pavel Machek wrote:
> Hi!
>
> > In the end, these patches remove pmdisk from the kernel and clean up the
> > swsusp code base. The result is a single code base with greatly improved
> > code, that will hopefully help others underestand it better.
>
> Followup patch:
>
> * if machine halt fails, it is very dangerous to continue.
>
> diff -ur linux.middle/kernel/power/disk.c linux/kernel/power/disk.c
> --- linux.middle/kernel/power/disk.c 2004-07-19 08:58:08.000000000 -0700
> +++ linux/kernel/power/disk.c 2004-07-19 15:00:16.000000000 -0700
> @@ -63,6 +63,9 @@
> break;
> }
> machine_halt();
> + /* Valid image is on the disk, if we continue we risk serious data corruption
> + after resume. */
> + while(1);
Would be nicer to use:
while(1)
/* Loop forever */;
Sam
next prev parent reply other threads:[~2004-07-20 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-17 22:34 Patrick Mochel
2004-07-18 22:04 ` Pavel Machek
2004-07-18 22:04 ` Nigel Cunningham
2004-07-19 1:24 ` Andrew Morton
2004-07-18 22:27 ` Pavel Machek
2004-08-02 5:13 ` Patrick Mochel
2004-07-20 16:46 ` Pavel Machek
2004-07-20 19:28 ` sam [this message]
2004-07-20 17:41 ` Dmitry Torokhov
2004-07-20 19:21 ` Pavel Machek
2004-08-02 5:42 ` Patrick Mochel
2004-08-06 19:43 ` Pavel Machek
2004-07-27 7:17 ` Felipe Alfaro Solana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040720192858.GB9147@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®