From: Pavel Machek <pavel@ucw.cz>
To: Patrick Mochel <mochel@digitalimplant.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: -mm swsusp: fix highmem handling
Date: Thu, 29 Jul 2004 00:23:00 +0200 [thread overview]
Message-ID: <20040728222300.GA16671@elf.ucw.cz> (raw)
Hi!
Swsusp was not restoring highmem properly. I did not find a nice place
where to restore it, through, so it went to swsusp_free.
I'm not sure why you are saving state before
save_processor_state. swsusp_arch_resume will overwrite this,
anyway. Is it to make something balanced?
Pavel
--- clean-mm/kernel/power/swsusp.c 2004-07-28 23:39:49.000000000 +0200
+++ linux-mm/kernel/power/swsusp.c 2004-07-28 23:30:33.000000000 +0200
@@ -656,6 +652,10 @@
free_suspend_pagedir_zone(zone, p);
}
free_pages(p, pagedir_order);
+#ifdef CONFIG_HIGHMEM
+ printk( "Restoring highmem\n" );
+ restore_highmem();
+#endif
}
@@ -890,7 +890,6 @@
{
int error;
local_irq_disable();
- save_processor_state();
error = swsusp_arch_resume();
restore_processor_state();
local_irq_enable();
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next reply other threads:[~2004-07-28 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 22:23 Pavel Machek [this message]
2004-08-02 6:13 ` Patrick Mochel
2004-08-06 21:11 ` Pavel Machek
2004-08-08 18:53 ` Pavel Machek
2004-08-09 12:48 Pavel Machek
2004-08-09 21:47 ` Andrew Morton
2004-08-09 21:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040728222300.GA16671@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®