From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: mochel@digitalimplant.org, linux-kernel@vger.kernel.org
Subject: Re: -mm swsusp: fix highmem handling
Date: Mon, 9 Aug 2004 14:47:08 -0700 [thread overview]
Message-ID: <20040809144708.13955e44.akpm@osdl.org> (raw)
In-Reply-To: <20040809124825.GA602@elf.ucw.cz>
Pavel Machek <pavel@ucw.cz> wrote:
>
> This fixes highmem handling, and adds some comments so that others do
> not fall into the same trap I fallen in: code does not continue below
> swsusp_arch_resume if things go okay.
>
> Please apply,
> Pavel
>
> --- clean-mm/kernel/power/swsusp.c 2004-07-28 23:39:49.000000000 +0200
> +++ linux-mm/kernel/power/swsusp.c 2004-08-09 11:54:04.000000000 +0200
> @@ -870,8 +866,12 @@
> local_irq_disable();
> save_processor_state();
> error = swsusp_arch_suspend();
> + /* Restore control flow magically appears here */
> restore_processor_state();
> local_irq_enable();
> +#ifdef CONFIG_HIGHMEM
> + restore_highmem();
> +#endif
> return error;
restore_highmem() is a noop if !CONFIG_HIGHMEM, so I shall remove the
above ifdef/endif.
next prev parent reply other threads:[~2004-08-09 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 12:48 Pavel Machek
2004-08-09 21:47 ` Andrew Morton [this message]
2004-08-09 21:52 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2004-07-28 22:23 Pavel Machek
2004-08-02 6:13 ` Patrick Mochel
2004-08-06 21:11 ` Pavel Machek
2004-08-08 18:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809144708.13955e44.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®