mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Stefan Meyknecht <sm0407@nurfuerspam.de>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH] cdrom: MO-drive open write fix (trivial)
Date: Fri, 6 Aug 2004 22:06:54 -0700	[thread overview]
Message-ID: <20040806220654.5e857bed.akpm@osdl.org> (raw)
In-Reply-To: <200408061833.30751.sm0407@nurfuerspam.de>

Stefan Meyknecht <sm0407@nurfuerspam.de> wrote:
>
> [PATCH] cdrom: MO-drive open write fix
> 
> Allow mounting mo-drives readwrite.
> 
> Please apply.
> 
> Stefan
> 
> 
> --- linux/drivers/cdrom/cdrom.c.orig	2004-08-06 18:04:16.269803330 +0200
> +++ linux/drivers/cdrom/cdrom.c	2004-08-06 18:04:33.570828588 +0200
> @@ -899,7 +899,7 @@ int cdrom_open(struct cdrom_device_info 
>  			ret = -EROFS;
>  			if (cdrom_open_write(cdi))
>  				goto err;
> -			if (!CDROM_CAN(CDC_RAM))
> +			if (!CDROM_CAN(CDC_RAM) && !CDROM_CAN(CDC_MO_DRIVE))
>  				goto err;
>  			ret = 0;
>  		}

I forwarded this to Jens last time you sent it and he said "Not really,
CDC_RAM is an umbrella that should already cover these devices.  I'll reply
to him."

So...  could you describe the actual bug which you're seeing - maybe
there's some different fix which we need.


  reply	other threads:[~2004-08-07  5:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-06 16:33 Stefan Meyknecht
2004-08-07  5:06 ` Andrew Morton [this message]
2004-08-07  8:38   ` Jens Axboe
2004-08-07 10:35     ` Stefan Meyknecht
2004-08-07 12:12     ` Stefan Meyknecht
2004-08-07 21:57       ` Alan Cox
2004-08-09  6:33       ` Jens Axboe
2004-08-13 17:17         ` Stefan Meyknecht
2004-08-13 17:26           ` Jens Axboe
2004-08-13 17:47             ` Stefan Meyknecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040806220654.5e857bed.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sm0407@nurfuerspam.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®