mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Meyknecht <sm0407@nurfuerspam.de>
To: Jens Axboe <axboe@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdrom: MO-drive open write fix (trivial)
Date: Sat, 7 Aug 2004 12:35:56 +0200	[thread overview]
Message-ID: <200408071235.56546.sm0407@nurfuerspam.de> (raw)
In-Reply-To: <20040807083835.GA24860@suse.de>

Hi,

thanks for your feedback.

Jens Axboe <axboe@suse.de> wrote:
> Sorry, guess I forgot to reply on linux-kernel. What I mean is that
> MO drives should just have CDC_RAM set - it doesn't denote a
> specific device type, rather just the ability to work like a hard
> drive. If you could look into why that isn't set for your mo device
> and send a patch for that, it would be much better.

You are right. After inserting some debug messages I found out that in 
function cdrom_open_write CDC_RAM is initially set. The function 
cdrom_is_random_writable sets ram_write to 0 and therefore CDC_RAM 
gets masked out later. cdrom_is_random_writable calls 
cdrom_get_random_writable and there cdi->ops->generic_packet returns 
-5 (-EIO?). But I have no idea what to do in this case.

-- 
Stefan Meyknecht
stefan at meyknecht dot org

  reply	other threads:[~2004-08-07 10:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-06 16:33 Stefan Meyknecht
2004-08-07  5:06 ` Andrew Morton
2004-08-07  8:38   ` Jens Axboe
2004-08-07 10:35     ` Stefan Meyknecht [this message]
2004-08-07 12:12     ` Stefan Meyknecht
2004-08-07 21:57       ` Alan Cox
2004-08-09  6:33       ` Jens Axboe
2004-08-13 17:17         ` Stefan Meyknecht
2004-08-13 17:26           ` Jens Axboe
2004-08-13 17:47             ` Stefan Meyknecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408071235.56546.sm0407@nurfuerspam.de \
    --to=sm0407@nurfuerspam.de \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®