From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] kbuild: Remove LANG preset in top-level Makefile
Date: Sat, 7 Aug 2004 19:54:48 +0200 [thread overview]
Message-ID: <20040807175448.GA20456@mars.ravnborg.org> (raw)
Hi Linus, please apply before 2.6.8 final!
In the top-level Makefile a number of locale related
environment variables were preset to give a small
speed up when building the kernel.
Unfortunately this had the bad sideeffect that the
variable CFLAGS_vmlinux.lds.o lost the exported vaule in
some setups (obviously not mine).
This smells like a make issue - but the best solution is simply
to drop presetting the locale related variables.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
===== Makefile 1.509 vs edited =====
--- 1.509/Makefile 2004-08-03 23:11:35 +02:00
+++ edited/Makefile 2004-08-07 19:44:40 +02:00
@@ -619,12 +619,7 @@
.PHONY: $(vmlinux-dirs)
$(vmlinux-dirs): prepare-all scripts
- $(Q)if [ ! -z $$LC_ALL ]; then \
- export LANG=$$LC_ALL; \
- export LC_ALL= ; \
- fi; \
- export LC_COLLATE=C; export LC_CTYPE=C; \
- $(MAKE) $(build)=$@
+ $(Q)$(MAKE) $(build)=$@
# Things we need to do before we recursively start building the kernel
# or the modules are listed in "prepare-all".
reply other threads:[~2004-08-07 17:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040807175448.GA20456@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®