mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kbuild: Remove LANG preset in top-level Makefile
@ 2004-08-07 17:54 Sam Ravnborg
  0 siblings, 0 replies; only message in thread
From: Sam Ravnborg @ 2004-08-07 17:54 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Andrew Morton

Hi Linus, please apply before 2.6.8 final!

In the top-level Makefile a number of locale related
environment variables were preset to give a small
speed up when building the kernel.
Unfortunately this had the bad sideeffect that the
variable CFLAGS_vmlinux.lds.o lost the exported vaule in
some setups (obviously not mine).
This smells like a make issue - but the best solution is simply
to drop presetting the locale related variables.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

===== Makefile 1.509 vs edited =====
--- 1.509/Makefile	2004-08-03 23:11:35 +02:00
+++ edited/Makefile	2004-08-07 19:44:40 +02:00
@@ -619,12 +619,7 @@
 
 .PHONY: $(vmlinux-dirs)
 $(vmlinux-dirs): prepare-all scripts
-	$(Q)if [ ! -z $$LC_ALL ]; then          \
-		export LANG=$$LC_ALL;           \
-		export LC_ALL= ;                \
-	fi;                                     \
-	export LC_COLLATE=C; export LC_CTYPE=C; \
-	$(MAKE) $(build)=$@
+	$(Q)$(MAKE) $(build)=$@
 
 # Things we need to do before we recursively start building the kernel
 # or the modules are listed in "prepare-all".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-08-07 17:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-07 17:54 [PATCH] kbuild: Remove LANG preset in top-level Makefile Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®