From: Muli Ben-Yehuda <mulix@mulix.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, Stelian Pop <stelian@popies.net>,
jgarzik@pobox.com
Subject: Re: [patch] fix netconsole hang with alt-sysrq-t
Date: Fri, 13 Aug 2004 00:39:36 +0300 [thread overview]
Message-ID: <20040812213936.GC17907@granada.merseine.nu> (raw)
In-Reply-To: <16667.57829.212177.183803@segfault.boston.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Thu, Aug 12, 2004 at 05:32:21PM -0400, Jeff Moyer wrote:
> ==> Regarding Re: [patch] fix netconsole hang with alt-sysrq-t; Muli Ben-Yehuda <mulix@mulix.org> adds:
>
> mulix> On Thu, Aug 12, 2004 at 05:01:18PM -0400, Jeff Moyer wrote:
> >> So how do you want to deal with this case? We could do something like:
> >>
> >> int cpu = smp_processor_id();
>
> mulix> That doesn't look right, unless I'm missing something, you could get
> mulix> preempted here (between the smp_processor_id() and the
> mulix> local_irq_save() and end up with 'cpu' pointing to the wrong CPU.
>
> Would a preempt_disable() be too hideous? Other suggestions?
Maybe, but we could hide it in get_cpu() / put_cpu() ;-)
Cheers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-08-12 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-06 19:29 Jeff Moyer
2004-08-06 19:52 ` Matt Mackall
2004-08-06 20:01 ` Jeff Moyer
2004-08-06 20:26 ` Matt Mackall
2004-08-12 21:01 ` Jeff Moyer
2004-08-12 21:18 ` Muli Ben-Yehuda
2004-08-12 21:32 ` Jeff Moyer
2004-08-12 21:39 ` Muli Ben-Yehuda [this message]
2004-08-13 0:21 ` Matt Mackall
2004-08-13 0:29 ` Matt Mackall
2004-08-16 18:41 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040812213936.GC17907@granada.merseine.nu \
--to=mulix@mulix.org \
--cc=jgarzik@pobox.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®